Hi Hong, Marina, Jerome, Jan, Byron, Satish, Ken, Jagadish, Sahoo,
I've attached another patch (msg-single-quotes-local.patch) with a fix
for the issues in LocalStrings.properties and Bundle.properties; see:
https://glassfish.dev.java.net/issues/show_bug.cgi?id=9896
This is in addition to the msg-single-quotes.patch I asked a review for
two days ago.
- deployment/dol (Hong)
- persistence/cmp (Marina?)
- core/kernel (Jerome?)
- web (Jan)
- admin (Byron)
- jms (Satish)
- ejb (Ken S.)
- connectors (Jagadish)
- verifier (Sahoo?)
Could you give me the OK to commit them?
Thanks,
Dies
Dies Koper wrote:
> Hi Jan, Byron, Shin-Wai, admin/monitor owner,
>
> I have attached a patch to issue #9896 (issue #4 in my previous list),
> please review.
>
> admin/monitor (?):
> admin\monitor\src\main\java\org\glassfish\admin\monitor\LogStrings.properties
>
>
> common-util (Byron?):
> common\common-util\src\main\java\com\sun\logging\enterprise\system\tools\launcher\LogStrings.properties
>
> common\common-util\src\main\java\com\sun\logging\enterprise\system\tools\admin\LogStrings.properties
>
> common\common-util\src\main\java\com\sun\logging\enterprise\system\core\selfmanagement\LogStrings.properties
>
>
> security (Shin-Wai?):
> security\core\src\main\resources\com\sun\logging\enterprise\system\core\security\LogStrings.properties
>
>
> web (Jan):
> web\war-util\src\main\resources\com\sun\logging\enterprise\system\container\web\LogStrings.properties
>
>
> This patch only covers the issues in LogStrings.properties.
> I hope to send out a patch review request for the remaining message
> files by Monday or Tuesday. If you think you might be too busy to review
> a patch then, would you consider authorizing someone (Carla, for
> instance, or even just me) to review it so I can commit it before HCF?
> Note that the only changes I'm making here are for the single quotes issue.
>
> Thanks,
> Dies
>
>
> Dies Koper wrote:
>> Hi,
>>
>> We had several threads about the messages: that they need message IDs,
>> diag info and (not much discussed) be externalized for localization.
>> Sekhar has even prepared a tool to help.
>>
>> Since then I think everybody has been too busy to actually do the work.
>>
>> I'd like to help out where I can, and already sent out a patch to
>> Shalini directly for jdbc, but felt we still have different opinions
>> about what to do. I'd like to move the discussion here to explain my
>> intentions so that all the module owners for whom I might prepare
>> similar patches are in agreement with it.
>>
>> For now, I'd like to fix the following issues:
>>
>> 1. Messages with no ID
>>
>> 2. Typos (just the obvious ones, I'm not a professional proofreader)
>>
>> 3. Message ID (layout) issues (such as space in "RAR 7014")
>>
>> 4. Single apostrophes in messages with arguments (see issue #9896)