dev@glassfish.java.net

Request for pom.xml review

From: Shalini Muthukrishnan <Shalini.Muthukrishnan_at_Sun.COM>
Date: Tue, 03 Nov 2009 19:28:12 +0530

Please review the proposed changes to
1. pom.xml of jdbc,
2. pom.xml of jdbc-ra-distribution and
3. a new pom.xml under jdbc/dbvendormapping (attached pom.xml).

Below are the diffs and attached are the original files.

Index: jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml
===================================================================
--- jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml (revision 33699)
+++ jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml (working copy)
@@ -26,11 +26,13 @@
                 <resolveArtifact artifactId="jdbc30"
groupId="org.glassfish.jdbc.jdbc-ra.jdbc30" property="30.jar"/>
                 <resolveArtifact artifactId="jdbc40"
groupId="org.glassfish.jdbc.jdbc-ra.jdbc40" property="40.jar"/>
         <resolveArtifact artifactId="templates"
groupId="org.glassfish.jdbc" property="templates.jar"/>
+ <resolveArtifact artifactId="dbvendormapping"
groupId="org.glassfish.jdbc" property="dbvendormapping.jar"/>
 
             <unjar src="${core.jar}" dest="target/classes"/>
             <unjar src="${30.jar}" dest="target/classes"/>
             <unjar src="${40.jar}" dest="target/classes"/>
         <unjar src="${templates.jar}" dest="target/classes/templates"/>
+ <unjar src="${dbvendormapping.jar}"
dest="target/classes/dbvendormapping"/>
 
         <!-- Creating jars/rars done using ant build.xml -->
                 <property name="compile_classpath"
refid="maven.compile.classpath"/>
@@ -80,5 +82,11 @@
       <type>distribution-fragment</type>
     </dependency>
 
+ <dependency>
+ <groupId>org.glassfish.jdbc</groupId>
+ <artifactId>dbvendormapping</artifactId>
+ <version>${project.parent.version}</version>
+ <type>distribution-fragment</type>
+ </dependency>
   </dependencies>
 </project>

Index: jdbc/pom.xml
===================================================================
--- jdbc/pom.xml (revision 33699)
+++ jdbc/pom.xml (working copy)
@@ -71,5 +71,6 @@
         <module>jdbc-ra</module>
         <module>admin</module>
     <module>templates</module>
+ <module>dbvendormapping</module>
     </modules>
 </project>

Thanks,
Shalini.