dev@glassfish.java.net

Re: Please review pom.xml files

From: Ken Paulsen <Ken.Paulsen_at_Sun.COM>
Date: Mon, 09 Nov 2009 14:28:07 -0800

Hi Kim,

I am not a fan of how you are naming the versions, please see:

    
http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution

Because of how you are specifying your version numbers, maven will not
be able to accurately compare them to determine the oldest/newest
version. I would suggest:

    3.0.0-6

Thanks!

Ken

Kim Haase wrote:
> Please review the following pom.xml changes needed to bump the version
> number for the v3-docs and to correct the name of the help artifact
> for JavaMail/JNDI.
>
> Thanks very much.
>
> Kim Haase
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 33922)
> +++ pom.xml (working copy)
> @@ -158,7 +158,7 @@
> <findbugs.exclude></findbugs.exclude>
> <btrace.version>1.0.5</btrace.version>
> <opendmk.version>1.0-b01-ea</opendmk.version>
> - <v3-docs.version>3.0-b05</v3-docs.version>
> + <v3-docs.version>3.0-b06</v3-docs.version>
> <l10n.version>3.0-b70</l10n.version>
> </properties>
>
> @@ -1032,7 +1032,7 @@
> </dependency>
> <dependency>
> <groupId>org.glassfish.admingui</groupId>
> - <artifactId>console-jmail-plugin-help</artifactId>
> + <artifactId>console-common-full-plugin-help</artifactId>
> <version>${v3-docs.version}</version>
> </dependency>
> <dependency>
> Index: packager/glassfish-common-full/pom.xml
> ===================================================================
> --- packager/glassfish-common-full/pom.xml (revision 33939)
> +++ packager/glassfish-common-full/pom.xml (working copy)
> @@ -106,7 +106,7 @@
> </dependency>
> <dependency>
> <groupId>org.glassfish.admingui</groupId>
> - <artifactId>console-jmail-plugin-help</artifactId>
> + <artifactId>console-common-full-plugin-help</artifactId>
> </dependency>
> <!-- now, listing package dependencies so that their content
> can be excluded during staging -->
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>