dev@glassfish.java.net

Re: Pls review pom.xml

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Mon, 24 Aug 2009 10:20:32 -0700

Hi Bhakti,

The path separator is a different issue. When I remove rt.jar, it
builds successfully. Can you try removing rt.jar and compile on a Mac
and non-Mac platforms. Also, do you know if the code is referencing any
packages from rt.jar/classes.jar?

Thanks,
Jane


Bhakti Mehta wrote:
> Jane,
> Remember the build failed on windows due to path separator issue which
> you fixed. rt.jar should be there when we add bootclasspath
> I am sure it will fail on non mac platforms without rt.jar
> Regards,
> Bhakti
>
> Jane Young wrote:
>> Hi Bhakti,
>>
>> Is webservices/jsr109-impl referencing packages in
>> rt.jar/classes.jar? When I remove rt.jar from bootclasspath, the
>> module built successfully. If it's not needed, perhaps remove rt.jar
>> instead of adding classes.jar?
>>
>> Thanks,
>> Jane
>>
>>
>> Bhakti Mehta wrote:
>>> Jane,
>>> I read your feedback to Hong and would request to add this to the
>>> pom.xml so that Classes.jar is found in bootclasspath
>>> Please can you approve
>>>
>>> Thanks,
>>> Bhakti
>>> ===================================================================
>>> --- pom.xml (revision 30728)
>>> +++ pom.xml (working copy)
>>> @@ -86,7 +86,7 @@
>>> <artifactId>hk2-maven-plugin</artifactId>
>>> <configuration>
>>> <compilerArguments>
>>> -
>>> <bootclasspath>${project.build.directory}/endorsed/webservices-api-osgi-${webservices.version}.jar${path.separator}${project.build.directory}/endorsed/jaxb-api-osgi-${jaxb.version}.jar${path.separator}${java.home}/lib/rt.jar</bootclasspath>
>>>
>>> +
>>> <bootclasspath>${project.build.directory}/endorsed/webservices-api-osgi-${webservices.version}.jar${path.separator}${project.build.directory}/endorsed/jaxb-api-osgi-${jaxb.version}.jar${path.separator}${java.home}/../Classes/classes.jar${path.separator}${java.home}/lib/rt.jar</bootclasspath>
>>>
>>> </compilerArguments>
>>> <fork>true</fork>
>>> <archive>
>>>
>>