dev@glassfish.java.net

Re: pom.xml review request - use hk2 in asadmin

From: Sahoo <Sahoo_at_Sun.COM>
Date: Wed, 19 Aug 2009 10:25:34 +0530

Bill,

Since you are adding a dependency on com.sun.enterprise.hk2, why not add
a classpath entry for hk2.jar instead of hk2-core.jar? hk2.jar has
following classpath manifest entry:

tiger-types-osgi.jar hk2-core.jar auto-depends.jar bean-validator.jar
config.jar

Thanks,
Sahoo

Bill Shannon wrote:
> Before I check in the changes to asadmin to use hk2, would someone please
> review the corresponding admin/cli/pom.xml changes?
>
> Thanks!
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 30538)
> +++ pom.xml (working copy)
> @@ -136,7 +136,7 @@
>
> <mainClass>com.sun.enterprise.admin.cli.AsadminMain</mainClass>
> </manifest>
> <manifestEntries>
> - <Class-Path>cli-optional.jar glassfish.jar server-mgmt.jar common-util.jar
> admin-util.jar launcher.jar backup.jar stax-osgi.jar admin-cli-l10n.jar
> security.jar glassfish-api.jar</Class-Path>
> + <Class-Path>cli-optional.jar glassfish.jar server-mgmt.jar common-util.jar
> admin-util.jar launcher.jar backup.jar stax-osgi.jar admin-cli-l10n.jar
> security.jar glassfish-api.jar hk2.jar hk2-core.jar</Class-Path>
> <!-- 5776: we do not need backup jar entry, but I
> retain it, Kedar -->
> </manifestEntries>
> </archive>
> @@ -217,5 +217,9 @@
> <artifactId>glassfish-api</artifactId>
> <version>${project.parent.version}</version>
> </dependency>
> + <dependency>
> + <groupId>com.sun.enterprise</groupId>
> + <artifactId>hk2</artifactId>
> + </dependency>
> </dependencies>
> </project>
>
>
>
> (BTW, why is the groupId for hk2 "com.sun.enterprise" instead of
> "org.jvnet.hk2"?)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>