dev@glassfish.java.net

Re: Please review pom.xml

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Fri, 14 Aug 2009 10:53:27 -0700

Apologize for the late response.
I took your pom.xml and compiled locally and didn't find any issue
with this.
The changes look fine.


Bhakti Mehta wrote:
> Any update on this?
> Regards,
> Bhakti
>
> Bhakti Mehta wrote:
>> Jane/Sahoo/Jerome,
>> Please can you review the following pom
>> webservices/jsr109-impl/pom.xml . JAXWS and JAXB 2.0 are in JDK 6. I
>> am using newer apis from JAXWS 2.2 in jsr 109-impl src code. Hence I
>> need to specify bootclasspath to override the apis from JDK 6 with
>> the newer JAXWS/JAXB 2.2 at compile time . So I used the dependency
>> plugin with copy goal to copy those files to target/endorsed then set
>> the bootclasspath which was passed to apt which is used by
>> hk2-maven-plugin.
>>
>> Once you approve this change I can commit my src code.
>> Btw I have tested this only on mac but I hope this will work for all
>> platforms
>> Regards,
>> Bhakti
>>
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 30381)
>> +++ pom.xml (working copy)
>> @@ -49,42 +49,49 @@
>> <artifactId>jsr109-impl</artifactId>
>> <packaging>hk2-jar</packaging>
>> <name>JSR-109 implementation to deploy Metro</name>
>> - <!--<build>
>> - <plugins>
>> - - <plugin>
>> - <groupId>com.sun.enterprise</groupId>
>> - <artifactId>hk2-maven-plugin</artifactId>
>> - <configuration>
>>
>> - <configFiles>
>> -
>> <configFile>src/main/resources/wsgen</configFile>
>> -
>> - </configFiles>
>> - <destDir>target/classes</destDir>
>> - - </configuration>
>> - <executions>
>> - <execution>
>> - <phase>compile</phase>
>> - <goals>
>> - <goal>createscripts</goal>
>> - </goals>
>> - </execution>
>> - </executions>
>> - </plugin>
>> - </plugins>
>> - </build>
>> --->
>> - <build>
>> + <build>
>> <plugins>
>> <plugin>
>> + <artifactId>maven-dependency-plugin</artifactId>
>> + <executions>
>> + <execution>
>> + <phase>process-resources</phase>
>> + <goals>
>> + <goal>copy</goal>
>> + </goals>
>> + <configuration>
>> + <artifactItems>
>> + <artifactItem>
>> + <groupId>javax.xml</groupId>
>> +
>> <artifactId>webservices-api-osgi</artifactId>
>> +
>> <outputDirectory>${project.build.directory}/endorsed</outputDirectory>
>> +
>> <version>${webservices.version>}</version>
>> +
>> + </artifactItem>
>> + <artifactItem>
>> + <groupId>javax.xml.bind</groupId>
>> +
>> <artifactId>jaxb-api-osgi</artifactId>
>> +
>> <outputDirectory>${project.build.directory}/endorsed</outputDirectory>
>> + <version>${jaxb.version}</version>
>> + </artifactItem>
>> + </artifactItems>
>> + </configuration>
>> + </execution>
>> + </executions>
>> + </plugin>
>> +
>> + <plugin>
>> <groupId>com.sun.enterprise</groupId>
>> <artifactId>hk2-maven-plugin</artifactId>
>> <configuration>
>> + <compilerArguments>
>> +
>> <bootclasspath>${project.build.directory}/endorsed/webservices-api-osgi-${webservices.version}.jar:${project.build.directory}/endorsed/jaxb-api-osgi-${jaxb.version}.jar:${java.home}/lib/rt.jar</bootclasspath>
>>
>> + </compilerArguments>
>> + <fork>true</fork>
>> <archive>
>> <manifestEntries>
>> -
>> <probe-provider-class-names>org.glassfish.webservices.monitoring.Deployment109ProbeProvider</probe-provider-class-names>
>>
>> +
>> <probe-provider-class-names>org.glassfish.webservices.monitoring.Deployment109ProbeProvider</probe-provider-class-names>
>>
>> </manifestEntries>
>> </archive>
>> </configuration>
>> @@ -144,51 +151,51 @@
>> </dependency>
>>
>> <dependency>
>> - <groupId>org.glassfish.common</groupId>
>> + <groupId>org.glassfish.common</groupId>
>> <artifactId>container-common</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>> <dependency>
>> - <groupId>org.glassfish.web</groupId>
>> + <groupId>org.glassfish.web</groupId>
>> <artifactId>web-glue</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>> <dependency>
>> - <groupId>com.sun.xml.ws</groupId>
>> + <groupId>com.sun.xml.ws</groupId>
>> <artifactId>webservices-osgi</artifactId>
>> </dependency>
>> <dependency>
>> - <groupId>javax.xml</groupId>
>> + <groupId>javax.xml</groupId>
>> <artifactId>webservices-api-osgi</artifactId>
>> </dependency>
>> <dependency>
>> - <groupId>com.sun.xml.bind</groupId>
>> + <groupId>com.sun.xml.bind</groupId>
>> <artifactId>jaxb-osgi</artifactId>
>> </dependency>
>> <dependency>
>> - <groupId>javax.xml.bind</groupId>
>> + <groupId>javax.xml.bind</groupId>
>> <artifactId>jaxb-api-osgi</artifactId>
>> </dependency>
>> <dependency>
>> - <groupId>org.glassfish</groupId>
>> + <groupId>org.glassfish</groupId>
>> <artifactId>javax.ejb</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>> <dependency>
>> - <groupId>org.glassfish.ejb</groupId>
>> + <groupId>org.glassfish.ejb</groupId>
>> <artifactId>ejb-internal-api</artifactId>
>> <version>${project.version}</version>
>> </dependency>
>> <dependency>
>> - <groupId>com.sun.grizzly</groupId>
>> + <groupId>com.sun.grizzly</groupId>
>> <artifactId>grizzly-http-servlet</artifactId>
>> </dependency>
>> <dependency>
>> - <groupId>com.sun.grizzly</groupId>
>> + <groupId>com.sun.grizzly</groupId>
>> <artifactId>grizzly-utils</artifactId>
>> </dependency>
>>
>>
>> - +
>> </dependencies>
>> </project>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>>