Comments:
* Please change copyright date to 2009
* Why are you specifying the <repositories> element? You can remove
this since it's specified in v3/pom.xml.
* Remove: <version>${hk2.version}</version> since it's defined in
the dependencyManagement of v3/pom.xml.
* Please add jersey dependency in depenencyManagement of v3/pom.xml and
remove <version>${jersey.version}</version>.
Thanks,
Jane
Rajeshwar Patil wrote:
> Thanks Llyod for review.
>
> When I implemented the functionality, these were the interfaces I
> found and used.
> I will remove the dependency on stats77 jar and use the newly
> available stats interfaces from glassfish-api
>
> Thanks
> Rajeshwar
>
>
>
> Lloyd Chambers wrote:
>> Do we really want REST to depend on J2EE?
>>
>> Talk to Sreeni about the alternatives.
>>
>> lloyd
>>
>> On Jul 6, 2009, at 8:11 AM, Rajeshwar Patil wrote:
>>
>>> Hello Jane, Jerome, Sahoo
>>>
>>> Please review attached pom.xml for rest module. I am also adding
>>> rest module entry in admin module's pom.xml. Please review.
>>>
>>> C:\src\gfv3\v3\admin>svn diff pom.xml
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 28406)
>>> +++ pom.xml (working copy)
>>> @@ -63,5 +63,6 @@
>>> <!-- not needed at the moment -->
>>> <module>launcher</module>
>>> <module>javax.management.j2ee</module>
>>> + <module>rest</module>
>>> </modules>
>>> </project>
>>>
>>>
>>> Thanks
>>> Rajeshwar
>>> <?xml version="1.0" encoding="UTF-8"?>
>>> <!--
>>> /*
>>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
>>> *
>>> * Copyright 1997-2007 Sun Microsystems, Inc. All rights reserved.
>>> *
>>> * The contents of this file are subject to the terms of either the GNU
>>> * General Public License Version 2 only ("GPL") or the Common
>>> Development
>>> * and Distribution License("CDDL") (collectively, the "License"). You
>>> * may not use this file except in compliance with the License. You
>>> can obtain
>>> * a copy of the License at
>>> https://glassfish.dev.java.net/public/CDDL+GPL.html
>>> * or glassfish/bootstrap/legal/LICENSE.txt. See the License for the
>>> specific
>>> * language governing permissions and limitations under the License.
>>> *
>>> * When distributing the software, include this License Header Notice
>>> in each
>>> * file and include the License file at
>>> glassfish/bootstrap/legal/LICENSE.txt.
>>> * Sun designates this particular file as subject to the "Classpath"
>>> exception
>>> * as provided by Sun in the GPL Version 2 section of the License
>>> file that
>>> * accompanied this code. If applicable, add the following below the
>>> License
>>> * Header, with the fields enclosed by brackets [] replaced by your own
>>> * identifying information: "Portions Copyrighted [year]
>>> * [name of copyright owner]"
>>> *
>>> * Contributor(s):
>>> *
>>> * If you wish your version of this file to be governed by only the
>>> CDDL or
>>> * only the GPL Version 2, indicate your decision by adding
>>> "[Contributor]
>>> * elects to include this software in this distribution under the
>>> [CDDL or GPL
>>> * Version 2] license." If you don't indicate a single choice of
>>> license, a
>>> * recipient has the option to distribute your version of this file
>>> under
>>> * either the CDDL, the GPL Version 2 or to extend the choice of
>>> license to
>>> * its licensees as provided above. However, if you add GPL Version
>>> 2 code
>>> * and therefore, elected the GPL Version 2 license, then the option
>>> applies
>>> * only if the new code is made subject to such option by the copyright
>>> * holder.
>>> */
>>> -->
>>> <project xmlns="http://maven.apache.org/POM/4.0.0"
>>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
>>> http://maven.apache.org/maven-v4_0_0.xsd">
>>> <parent>
>>> <groupId>org.glassfish.admin</groupId>
>>> <artifactId>admin</artifactId>
>>> <version>3.0-SNAPSHOT</version>
>>> </parent>
>>> <modelVersion>4.0.0</modelVersion>
>>> <artifactId>rest-service</artifactId>
>>> <packaging>hk2-jar</packaging>
>>> <name>GlassFish Rest Interface</name>
>>> <description>Rest Interface for GlassFish Management and
>>> Monitoring</description>
>>>
>>> <developers>
>>> <developer>
>>> <id>ludo</id>
>>> <name>Ludovic Champenois</name>
>>> <url>http://weblogs.java.net/blog/ludo/</url>
>>> <organization>Sun Microsystems, Inc.</organization>
>>> <roles>
>>> <role>lead</role>
>>> <role>developer</role>
>>> </roles>
>>> </developer>
>>> <developer>
>>> <id>rajeshwar</id>
>>> <name>Rajeshwar Patil</name>
>>> <url>http://blogs.sun.com/aquatic/</url>
>>> <organization>Sun Microsystems, Inc.</organization>
>>> <roles>
>>> <role>lead</role>
>>> <role>developer</role>
>>> </roles>
>>> </developer>
>>> </developers>
>>> <repositories>
>>> <repository>
>>> <id>glassfish-repository</id>
>>> <name>Java.net Repository for Glassfish</name>
>>> <url>http://download.java.net/maven/glassfish</url>
>>> </repository>
>>> <repository>
>>> <id>maven2.java.net</id>
>>> <name>Java.net Repository for Maven 2</name>
>>> <url>http://download.java.net/maven/2</url>
>>> </repository>
>>> </repositories>
>>> <dependencies>
>>> <dependency>
>>> <groupId>com.sun.enterprise</groupId>
>>> <artifactId>hk2</artifactId>
>>> <version>${hk2.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.glassfish.common</groupId>
>>> <artifactId>glassfish-api</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.glassfish.common</groupId>
>>> <artifactId>common-util</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>com.sun.jersey</groupId>
>>> <artifactId>jersey-bundle</artifactId>
>>> <version>${jersey.version}</version>
>>> <scope>provided</scope>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.glassfish.flashlight</groupId>
>>> <artifactId>flashlight-framework</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> <groupId>org.glassfish.common</groupId>
>>> <artifactId>stats77</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> </dependencies>
>>> <build>
>>> <resources>
>>> <resource>
>>> <directory>src/main/java</directory>
>>> </resource>
>>> </resources>
>>> </build>
>>> </project>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> <mailto:dev-unsubscribe_at_glassfish.dev.java.net>
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>> <mailto:dev-help_at_glassfish.dev.java.net>
>>
>> Lloyd Chambers
>> lloyd.chambers_at_sun.com <mailto:lloyd.chambers_at_sun.com>
>> GlassFish Team
>>
>>
>>
>