dev@glassfish.java.net

Re: Please review appclient fixup.xml

From: Tim Quinn <Timothy.Quinn_at_Sun.COM>
Date: Thu, 23 Jul 2009 22:59:11 -0700

Shalini Muthukrishnan wrote:
> Hi Tim,
>
> They are different implementations of the same named classes. The
> latest one is added to support java.sql.Driver based pooling support.
OK. Thanks for the explanation.

- Tim
>
> Thanks,
> Shalini.
>
> Tim Quinn wrote:
>> The change to the fixup.xml looks OK to me.
>> Is it really the case that these various JARs that have been added
>> lately have completely different contents?
>> I listed the contents of several of them and there seem to be many
>> class names in common. Maybe they are all different implementations
>> of the same-named classes. But if they are really the same classes
>> then they need to be refactored out into one shared JAR that the
>> others refer to in their manifest Class-Path settings.
>>
>> Thanks.
>>
>> - Tim
>>
>> Shalini Muthukrishnan wrote:
>>> Hi,
>>>
>>> Please find the below diff in fixup.xml file. This is to add support
>>> for appclient container to refer to _dm_jdbc_ra_jar classes for
>>> manifest addition.
>>>
>>> Index: appclient/client/acc-standalone/fixup.xml
>>> ===================================================================
>>> --- appclient/client/acc-standalone/fixup.xml (revision 29674)
>>> +++ appclient/client/acc-standalone/fixup.xml (working copy)
>>> @@ -28,9 +28,10 @@
>>> <property name="ds-jdbcra.classpath.additions"
>>> value="../lib/install/applications/__ds_jdbc_ra/__ds_jdbc_ra.jar"/>
>>> <property name="cp-jdbcra.classpath.additions"
>>> value="../lib/install/applications/__cp_jdbc_ra/__cp_jdbc_ra.jar"/>
>>> <property name="xa-jdbcra.classpath.additions"
>>> value="../lib/install/applications/__xa_jdbc_ra/__xa_jdbc_ra.jar"/>
>>> + <property name="dm-jdbcra.classpath.additions"
>>> value="../lib/install/applications/__dm_jdbc_ra/__dm_jdbc_ra.jar"/>
>>> <property name="derby.jar.classpath.additions"
>>> value="../../javadb/lib/derby.jar ../../javadb/lib/derbyclient.jar
>>> ../../javadb/lib/derbynet.jar ../../javadb/lib/derbytools.jar
>>> ../../javadb/lib/derbyrun.jar"/>
>>> <property name="jaxr-ra.classpath.additions"
>>> value="../lib/install/applications/jaxr-ra/jaxr-ra.jar"/>
>>> - <property name="classpath.additions"
>>> value="${mq.classpath.additions} ${ds-jdbcra.classpath.additions}
>>> ${cp-jdbcra.classpath.additions} ${xa-jdbcra.classpath.additions}
>>> ${derby.jar.classpath.additions} ${jaxr-ra.classpath.additions}"/>
>>> + <property name="classpath.additions"
>>> value="${mq.classpath.additions} ${ds-jdbcra.classpath.additions}
>>> ${cp-jdbcra.classpath.additions} ${xa-jdbcra.classpath.additions}
>>> ${dm-jdbcra.classpath.additions} ${derby.jar.classpath.additions}
>>> ${jaxr-ra.classpath.additions}"/>
>>> <target name="fixup.library">
>>> <unzip src="${output.dir}/${output.file}" dest="${stage.dir}">
>>> <patternset>
>>>
>>> Thanks,
>>> Shalini.
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>