Hi Sahoo,
Thanks for the suggestion. I think that will work.
I will remove the stage directory after creating the zip file.
Thanks,
Jane
Sahoo wrote:
> Jane,
>
> Can we remove the domain dir after creating the zip file so that we
> can rely on failonerror=true?
>
> Thanks for filing an issue to track this.
>
> Sahoo
>
> Jane Young wrote:
>> Hi Sahoo,
>>
>> The ant exec task that invokes create-domain has "failonerror"
>> attribute set to false so the build continues even though
>> create-domain fails. Adding "failonerror=true"does not solve this
>> issue since invoking "mvn install" on a workspace that already has
>> the default domain created in the target directory will fail.
>>
>> We may have to add a check to verify that domain1 directory is
>> present before creating the zip distribution.
>>
>> Filed an IT to track this issue:
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=8790
>>
>> Thanks,
>> Jane
>>
>>
>>
>> Sahoo wrote:
>>> This has to be a bug in the build system; we can't report the build
>>> as a success if the final output is incomplete. In this case, I am
>>> not sure what went wrong. Did the asadmin command report a false
>>> success status or it failed, but our maven scripts are not written
>>> carefully to handle the failure? Do you know? The latter used to be
>>> the case when I had reported a similar issue sometime back. In any
>>> case, I suggest we add a simple unit test to distributions module to
>>> test if domain1 directory is present in the zip file or not.
>>>
>>> Thanks,
>>> Sahoo
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>