dev@glassfish.java.net

Re: [GFv3] No domain1 dir in glassfish.zip

From: Sahoo <Sahoo_at_Sun.COM>
Date: Tue, 21 Jul 2009 10:07:36 +0530

This has to be a bug in the build system; we can't report the build as a
success if the final output is incomplete. In this case, I am not sure
what went wrong. Did the asadmin command report a false success status
or it failed, but our maven scripts are not written carefully to handle
the failure? Do you know? The latter used to be the case when I had
reported a similar issue sometime back. In any case, I suggest we add a
simple unit test to distributions module to test if domain1 directory is
present in the zip file or not.

Thanks,
Sahoo

Jane Young wrote:
> I just send an e-mail to Bill. This is related to his commit, rev: 29461.
> Hudson continuous build is failing:
> http://gf-hudson.sfbay/hudson/job/gf-trunk-build-continuous/
>
> During the build, create-domain is invoked to create the default
> domain1 and it's failing since --checkports option is not invalid.
> See:
>
> create-domain:
> [echo] Directory to run command from:
> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/distributions/nucleus/target/stage/glassfishv3/glassfish/bin
> [echo] Command to run:
> /export/home1/java_re/BUILD_AREA/workspace/gf-trunk-build-continuous/v3/distributions/nucleus/target/stage/glassfishv3/glassfish/bin/asadmin
> [exec] Deprecated syntax: create-domain, Options: [user]
> [exec] Invalid option: --checkports=false
> [exec] Command create-domain failed.
> [exec] Usage: create-domain [--adminport <adminport>] [--portbase
> <portbase>] [--profile <profile>] [--template <template>] [--domaindir
> <domaindir>] [--instanceport <instanceport>]
> [--savemasterpassword=true|false] [--domainproperties
> <domainproperties>] [--keytooloptions <keytooloptions>]
> [--savelogin=true|false] [--help=true|false] domain_name
> [exec] Result: 1
>
>
>
> Kedar Mhaswade wrote:
>> Hmm. Standard answer -- Hudson seems to be doing all right.
>>
>> Can you do "asadmin create-domain --adminport 4848 domain1" after the
>> fact?
>> What do you get?
>>
>>
>> Sahoo wrote:
>>> I just did a clean build and I don't see domain1 directory being
>>> part of glassfish.zip.
>>>
>>> Sahoo
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>