dev@glassfish.java.net

Re: ACTION: packager and admingui pom.xml review

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Fri, 17 Jul 2009 01:31:31 -0700

I don't see anything wrong with the pom.xml changes.
You may want to ask Snjezana for reviewing the packager changes.


Anissa Lam wrote:
> Hi,
>
> There are changes needed in the GUI plugin modules according to this
> plan
> http://sites.google.com/site/glassfishconsole/Home/v3-admin-console-modules
>
> This is the first step towards the above final plan.
>
> changes in
>
> packager/glasfish-gui/pom.xml
> - remove console-security-plugin
>
> packager/glassfish-jdbc-gui/pom.xml
> - add console-common-full-plugin
> - add console-jca-plugin
>
>
> admingui/pom.xml
> - remove security module
> - add full module
> - add jca module
>
> Quicklook pass for both Glassfish and web profile.
>
> Here is the diff:
>
> ~/Awork/V3/NOW 597) svn diff v3/packager
> Index: v3/packager/glassfish-gui/pom.xml
> ===================================================================
> --- v3/packager/glassfish-gui/pom.xml (revision 29310)
> +++ v3/packager/glassfish-gui/pom.xml (working copy)
> @@ -92,11 +92,6 @@
> </dependency>
> <dependency>
> <groupId>org.glassfish.admingui</groupId>
> - <artifactId>console-security-plugin</artifactId>
> - <version>${project.version}</version>
> - </dependency>
> - <dependency>
> - <groupId>org.glassfish.admingui</groupId>
> <artifactId>console-updatecenter-plugin</artifactId>
> <version>${project.version}</version>
> </dependency>
> Index: v3/packager/glassfish-jdbc-gui/pom.xml
> ===================================================================
> --- v3/packager/glassfish-jdbc-gui/pom.xml (revision 29310)
> +++ v3/packager/glassfish-jdbc-gui/pom.xml (working copy)
> @@ -76,6 +76,18 @@
> <artifactId>console-jdbc-plugin</artifactId>
> <version>${project.version}</version>
> </dependency>
> +
> + <dependency>
> + <groupId>org.glassfish.admingui</groupId>
> + <artifactId>console-common-full-plugin</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> +
> + <dependency>
> + <groupId>org.glassfish.admingui</groupId>
> + <artifactId>console-jca-plugin</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> <!-- now, listing package dependencies so that their content
> can be excluded during staging -->
>
>
> ~/Awork/V3/NOW/v3 621) svn diff admingui
>
> Index: admingui/war/pom.xml
> ===================================================================
> --- admingui/war/pom.xml (revision 29317)
> +++ admingui/war/pom.xml (working copy)
> @@ -76,7 +76,6 @@
> <groupId>com.sun.mojarra</groupId>
> <artifactId>mojarra-scales</artifactId>
> <version>${scales.version}</version>
> - <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>com.sun.jsftemplating</groupId>
> Index: admingui/pom.xml
> ===================================================================
> --- admingui/pom.xml (revision 29317)
> +++ admingui/pom.xml (working copy)
> @@ -85,12 +85,13 @@
> <module>core</module>
> <module>community-theme</module>
> <module>web</module>
> - <module>jdbc-gui</module>
> + <module>jdbc</module>
> + <module>jca</module>
> <module>jms-plugin</module>
> <module>ejb</module>
> <module>ejb-lite</module>
> <module>corba</module>
> - <module>security</module>
> + <module>full</module>
> <module>updatecenter</module>
> <module>war</module>
> <module>dist-fragment</module>
>
> Property changes on: admingui/ejb
> ___________________________________________________________________
> Name: svn:ignore
> + target
>
>
> Index: admingui/full/pom.xml
> ===================================================================
> --- admingui/full/pom.xml (revision 29334)
> +++ admingui/full/pom.xml (working copy)
> @@ -45,7 +45,7 @@
> <artifactId>console-common-full-plugin</artifactId>
> <packaging>hk2-jar</packaging>
> <name>Admin Console Plugin for common-full package</name>
> - <description>JavaMail and JNDI plugin bundle for Glassfish V3
> Admin Console</description>
> + <description>Plugin bundle for Glassfish v3 Admin Console
> common-full package</description>
>
> <developers>
> <developer>
> Index: admingui/web/pom.xml
> ===================================================================
> --- admingui/web/pom.xml (revision 29317)
> +++ admingui/web/pom.xml (working copy)
> @@ -83,6 +83,7 @@
> <dependency>
> <groupId>org.glassfish.common</groupId>
> <artifactId>glassfish-api</artifactId>
> + <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.glassfish.admingui</groupId>
> @@ -94,7 +95,7 @@
> <groupId>org.glassfish.admingui</groupId>
> <artifactId>console-common</artifactId>
> <version>${project.version}</version>
> - <scope>compile</scope>
> + <scope>provided</scope>
> </dependency>
> <dependency>
> <groupId>org.glassfish.admin</groupId>
>
> thanks
> Anissa.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>