dev@glassfish.java.net

Re: pom.xml review embedded-shell

From: Amy Roh <Amelia.Roh_at_Sun.COM>
Date: Wed, 15 Jul 2009 08:47:42 -0700

Ok. I'm planning to add embedded web api tests in tests/embedded. Let
me know if you prefer a different location.

Index: tests/embedded/inplanted/pom.xml
===================================================================
--- tests/embedded/inplanted/pom.xml (revision 29197)
+++ tests/embedded/inplanted/pom.xml (working copy)
@@ -103,5 +103,10 @@
              <version>4.3.1</version>
              <scope>test</scope>
          </dependency>
+ <dependency>
+ <groupId>org.glassfish.web</groupId>
+ <artifactId>web-embed-impl</artifactId>
+ <version>${project.version}</version>
+ </dependency>
     </dependencies>
  </project>

Jerome Dochez wrote:
> This is incorrect, not all embedded use cases will have the web
> container. If your tests use your web embedded API, they will need to
> import that bundle directly. The embedded-shell is for the users which
> only use the embedded APIs of glassfish-api to start and configure the
> appserver.
>
> Jerome
>
> On Jul 14, 2009, at 5:08 PM, Amy Roh wrote:
>
>> I'd like to add embedded web api related tests to tests/embedded and
>> need to add web-embed jar until we reduce the number of web bundles.
>>
>> Index: extras/embedded-shell/pom.xml
>> ===================================================================
>> --- extras/embedded-shell/pom.xml (revision 29145)
>> +++ extras/embedded-shell/pom.xml (working copy)
>> @@ -97,6 +97,11 @@
>> <groupId>org.glassfish.core</groupId>
>> <artifactId>glassfish</artifactId>
>> <version>${project.version}</version>
>> - </dependency>
>> + </dependency>
>> + <dependency>
>> + <groupId>org.glassfish.web</groupId>
>> + <artifactId>web-embed-impl</artifactId>
>> + <version>${project.version}</version>
>> + </dependency>
>> </dependencies>
>> </project>
>>
>> Thanks,
>> Amy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>