Yes, looks good. I am not sure about the value of adding a plugin
version property, but that's your call.
Thanks,
Sahoo
Kedar Mhaswade wrote:
> Attached is the change to v3/pom.xml I am planning to make.
> Please review.
>
> The configuration part still has to stay at the POMs of
> modules that want to use this plugin. I don't think all
> of the configuration of jaxb2 maven plugin can be made in
> the top-level-v3-pom.
>
> -Kedar
>
>
> Kedar Mhaswade wrote:
>>
>>
>> Sahoo wrote:
>>> Kedar Mhaswade wrote:
>>>>
>>>>
>>>> Sahoo wrote:
>>>>> Kedar Mhaswade wrote:
>>>>>> Let me check.
>>>>>>
>>>>> Let us know your findings.
>>>>
>>>> Maven dependency plugin shows me:
>>>> [INFO] Plugin Resolved: maven-jaxb2-plugin-0.7.1.jar
>>>> [INFO] Plugin Dependency Resolved:
>>>> maven-jaxb2-plugin-raw-0.7.1.jar
>>>> [INFO] Plugin Dependency Resolved: jaxb-impl-2.1.10.jar
>>>> [INFO] Plugin Dependency Resolved: jaxb-xjc-2.1.10.jar
>>>>
>>>> I guess that means without explicit versions, these are what I get.
>>>> I don't know where these numbers are specified.
>>>>
>>> In that case, don't take a chance. Lock the version to what you want
>>> to use, otherwise it may even start using SNAPSHOT version of the
>>> plugin.
>>>
>>> Secondly, irrespective of whether the plugin is used locally or not,
>>> add it in v3/pom.xml's dependencyManagement to avoid having multiple
>>> modules defining multiple versions of the same plugin.
>>
>> You mean <pluginManagement>, right?
>> Will do.
>>
>> Do I need to send another review request e-mail before committing the
>> change?
>>
>> -Kedar
>>
>>>
>>> Thanks,
>>> Sahoo
>>>> -Kedar
>>>>
>>>>>
>>>>> Thanks,
>>>>> Sahoo
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net