dev@glassfish.java.net

Re: POM change review ...

From: Kedar Mhaswade <Kedar.Mhaswade_at_Sun.COM>
Date: Wed, 10 Jun 2009 06:57:08 -0700

Sahoo wrote:
> This does not look correct,

That's quite possible, I am maven-challenged :-)

> or may be I am having the correct context.
> Where is the version of the newly introduced plugins specified?

The plugin is not newly introduced. It's newly used. I think the version
of jaxb plugin is just inherited from somewhere. Let me check.

> Secondly, why is the plugin not configured in v3/pom.xml under
> pluginManagement section?

Jaxb plugin is a candidate for that, I guess. Tim uses this plugin in
his client bean generation step, so maybe we should both inherit it
from v3/pom.xml. Is that what you suggest?

But the javadoc plugin is specific to my requirements from admin/cli, so,
I don't see any advantages of moving that around and I'd prefer it that way.

-Kedar

>
> Thanks,
> Sahoo
>
> Kedar Mhaswade wrote:
>> Hi Jane, others,
>>
>> I have an apology to make. I just merged branches/asadmin onto trunk
>> and in
>> the process, I also merged admin/cli/pom.xml. I checked the stuff in
>> to trunk
>> after successful run of QL and other tests. Since it was a merge I had to
>> get done first, I ended up asking for review after the commit. Hope this
>> is all right, given that the changes I am making are pretty localized:
>> - a call to JAXB:generate goal
>> - a reconfiguration of Javadoc plugin.
>>
>> Please review:
>>
>> --- trunk/v3/admin/cli/pom.xml (original)
>> +++ trunk/v3/admin/cli/pom.xml 2009-06-09 18:06:10+0000
>> @@ -109,6 +109,7 @@
>> <include>**/*.1</include>
>> <include>**/*.1m</include>
>> <include>**/*.5asc</include>
>> + <include>*command-names</include>
>> </includes>
>> </resource>
>> <resource>
>> @@ -148,8 +149,47 @@
>> </execution>
>> </executions>
>> </plugin>
>> + <plugin>
>> + <groupId>org.jvnet.jaxb2.maven2</groupId>
>> + <artifactId>maven-jaxb2-plugin</artifactId>
>> + <executions>
>> + <execution>
>> + <id>generate-command-metadata-classes</id>
>> + <goals>
>> + <goal>generate</goal>
>> + </goals>
>> + </execution>
>> + </executions>
>> + <configuration>
>> + <schemaLanguage>DTD</schemaLanguage>
>> +
>> <schemaDirectory>src/main/resources</schemaDirectory>
>> +
>> <generatePackage>org.glassfish.enterprise.admin.ncli.metadata</generatePackage>
>>
>> + <schemaIncludes>
>> + <include>cmd-metadata.dtd</include>
>> + </schemaIncludes>
>> + </configuration>
>> + </plugin>
>> </plugins>
>> </build>
>> + <reporting>
>> + <plugins>
>> + <plugin>
>> + <artifactId>maven-javadoc-plugin</artifactId>
>> + <configuration>
>> + <aggregate>true</aggregate>
>> + <minmemory>128m</minmemory>
>> + <maxmemory>512m</maxmemory>
>> + <source>1.5</source>
>> + <verbose>false</verbose>
>> + <linksource>true</linksource>
>> + <links>
>> + <link>http://java.sun.com/javase/6/docs/api/</link>
>> + </links>
>> + <show>private</show>
>> + </configuration>
>> + </plugin>
>> + </plugins>
>> + </reporting>
>> <dependencies>
>> <dependency>
>> <groupId>org.glassfish.admin</groupId>
>>
>>
>> Regards,
>> Kedar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>