dev@glassfish.java.net

Re: Review web-embed pom.xml changes

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Tue, 30 Jun 2009 11:01:07 -0700

Hi Amy,

You can remove dependencies on javax.servlet and web-core. Maven
transitive dependencies feature will include these dependencies from
web-embed-api.

Thanks,
Jane

Amy Roh wrote:
> Please review web-embed/pom.xml changes.
>
>
> Index: web/web-embed/impl/pom.xml
> ===================================================================
> --- web/web-embed/impl/pom.xml (revision 0)
> +++ web/web-embed/impl/pom.xml (revision 0)
> @@ -0,0 +1,82 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +/*
> +* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
> +*
> +* Copyright 1997-2009 Sun Microsystems, Inc. All rights reserved.
> +*
> +* The contents of this file are subject to the terms of either the GNU
> +* General Public License Version 2 only ("GPL") or the Common
> Development
> +* and Distribution License("CDDL") (collectively, the "License"). You
> +* may not use this file except in compliance with the License. You
> can obtain
> +* a copy of the License at
> https://glassfish.dev.java.net/public/CDDL+GPL.html
> +* or glassfish/bootstrap/legal/LICENSE.txt. See the License for the
> specific
> +* language governing permissions and limitations under the License.
> +*
> +* When distributing the software, include this License Header Notice
> in each
> +* file and include the License file at
> glassfish/bootstrap/legal/LICENSE.txt.
> +* Sun designates this particular file as subject to the "Classpath"
> exception
> +* as provided by Sun in the GPL Version 2 section of the License file
> that
> +* accompanied this code. If applicable, add the following below the
> License
> +* Header, with the fields enclosed by brackets [] replaced by your own
> +* identifying information: "Portions Copyrighted [year]
> +* [name of copyright owner]"
> +*
> +* Contributor(s):
> +*
> +* If you wish your version of this file to be governed by only the
> CDDL or
> +* only the GPL Version 2, indicate your decision by adding
> "[Contributor]
> +* elects to include this software in this distribution under the
> [CDDL or GPL
> +* Version 2] license." If you don't indicate a single choice of
> license, a
> +* recipient has the option to distribute your version of this file under
> +* either the CDDL, the GPL Version 2 or to extend the choice of
> license to
> +* its licensees as provided above. However, if you add GPL Version 2
> code
> +* and therefore, elected the GPL Version 2 license, then the option
> applies
> +* only if the new code is made subject to such option by the copyright
> +* holder.
> +*/
> +-->
> +<project xmlns="http://maven.apache.org/POM/4.0.0"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd">
> + <parent>
> + <groupId>org.glassfish.web</groupId>
> + <artifactId>web-embed</artifactId>
> + <version>3.0-SNAPSHOT</version>
> + </parent>
> + <modelVersion>4.0.0</modelVersion>
> + <artifactId>web-embed-impl</artifactId>
> + <name>GlassFish Web container Embedded Implementation</name>
> +
> + <developers>
> + <developer>
> + <id>amyroh</id>
> + <name>Amy Roh</name>
> + <url>http://weblogs.java.net/blog/amyroh</url>
> + <organization>Sun Microsystems, Inc.</organization>
> + <roles>
> + <role>developer</role>
> + </roles>
> + </developer>
> + </developers>
> + <build>
> + <resources>
> + </resources>
> + </build>
> + <dependencies>
> + <dependency>
> + <groupId>org.glassfish</groupId>
> + <artifactId>javax.servlet</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.web</groupId>
> + <artifactId>web-core</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.web</groupId>
> + <artifactId>web-embed-api</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + </dependencies>
> +</project>
>
>
>
> Index: web/pom.xml
> ===================================================================
> --- web/pom.xml (revision 28271)
> +++ web/pom.xml (working copy)
> @@ -65,6 +65,7 @@
> <module>webbeans-integration</module>
> <module>osgi-http</module>
> <module>osgi-web-container</module>
> + <module>web-embed</module>
> </modules>
>
> </project>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>