dev@glassfish.java.net

Re: LogHelper

From: Sahoo <Sahoo_at_Sun.COM>
Date: Tue, 23 Jun 2009 12:49:37 +0530

Bill Shannon wrote:
> Sahoo wrote:
>> Bill Shannon wrote:
>>>
>>> Anyone know why this class is creating an anonymous logger, which it
>>> then
>>> shares with anyone who asks?
>> I only refactored the methods out of Utils class to a separate class
>> called LogHelper as part of revision #756 [1]. I don't know why the
>> code was written that way in Utils.class. We should create a logger
>> in HK2 namespace.
>
> Maybe Jerome knows the history?
>
>>> And why does code *outside* of hk2 use this
>>> helper class rather than creating a Logger of their own?
>> Nobody outside HK2 should use this class.
>
> At least CommandRunnerImpl.java and AdminAdapter.java use it.
> NetBeans finds a few others as well.
>
> Who wants to clean this up?

I shall change LogHelper to create a Logger in HK2 namespace after
discussing with Jerome. The v3 usage has to be fixed by respective
module owners. I see this class being used in admin, bootstrap & server
modules.

Thanks,
Sahoo