Kedar,
Thanks. I've read through the source file quite thoroughly.
-- First, a common pool of options seems problematic for multiple
modules. Perhaps we need to rethink this in the context of the module-
based system. That is not the issue here, just mentioning it.
-- I agree that calling System.setProperty() is required, good choice
there. But I have doubts whether this should be considered a "non
restart" event; I would expect most code to check system properties
only once, and AFAIK polling is required to note changes to system
properties.
-- What should -Dfoo=bar do?
ISSUE
When I change anything in <java-config>, I am not seeing any restart
required. While the log message says "an attribute was changed,
restart required", the behavior is different. I can debug this to see
what is going on.
Lloyd
On Oct 13, 2008, at 8:02 AM, Kedar Mhaswade wrote:
>
>
> Jerome Dochez wrote:
>> yes Kedar did some change that were supposed to notify of server-
>> restart when the jvm-options are changed.
>> sof if this is not happening, we need to investigate.
>
> Here are the javadocs for the changes:
> http://fisheye4.atlassian.com/browse/glassfish-svn/trunk/v3/core/kernel/src/main/java/com/sun/enterprise/v3/admin/listener/GenericJavaConfigListener.java?r=23054#24
>
> If the JVM-option represents a system property NOT starting with "-
> Djava."
> or "-Djavax.", server will attempt to call System.setProperty() when
> you create it. System.clearProperty() will be called when removing
> such
> a property. Both setProperty() and clearProperty() are dynamically
> applicable
> and I have tested it as such.
>
> None of the attributes of java-config element are dynamically
> reconfigurable.
>
> None of the VM options like -server, -client, -ea, -X*, -XX* are
> dynamically reconfigurable.
>
> Please let me know if your findings conform with this specification.
> If not,
> it's a bug. I don't know why setting debug-enabled to true/false
> does not set
> the restart required flag because I do add this change to the
> NotProcessed
> items. Lloyd?
>
> In CLI, there is no command that tells you if server needs a restart,
> as of now. We need to implement it.
>
> Regards,
> Kedar
>
>> jerome
>> Lloyd Chambers wrote:
>>> Anissa,
>>>
>>> Jerome made some changes in this area and so did Kedar. A
>>> ConfigListener was added for java-config. But I think it's not
>>> working right in that case. Any change to jvm-options should
>>> require a restart, so that listener is doing something wrong..
>>>
>>> Lloyd
>>>
>>> ..............................................
>>> Lloyd Chambers
>>> lloyd.chambers_at_sun.com
>>> GlassFish team, LSARC member
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Oct 10, 2008, at 10:15 AM, Anissa Lam wrote:
>>>
>>>>
>>>> It used to be that creating a connection pool will show server
>>>> restart required. That seems to be fixed as i don't see that
>>>> anymore. Now, i need some case that will require server restart
>>>> for my testing. I have tried adding a <jvm-options>, change
>>>> <java-config> debug-enabled attribute, none of this shows
>>>> server restart is required. Is this true ?
>>>> Also, what CLI command will tell me that server require restart ?
>>>>
>>>> thanks
>>>> Anissa.
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>