Jagadish
Since you changed the package name, you could have used the new
package name for public APIS :
org.glassfish.api
so it could have been
org.glassfish.api.connectors
You don't have to change it again... but it would be nice.
Thanks, Jerome
On Feb 29, 2008, at 1:37 AM, jr158900_at_dev.java.net wrote:
> Author: jr158900
> Date: 2008-02-29 09:37:11+0000
> New Revision: 18349
>
> Modified:
> trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/PoolingException.java
> trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/ResourceHandle.java
> trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/TransactedPoolManager.java
>
> Log:
> Changing package names
>
>
>
> Modified: trunk/v3/common/glassfish-api/src/main/java/com/sun/
> appserv/connectors/spi/PoolingException.java
> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/PoolingException.java?view=diff&rev=18349&p1=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/PoolingException.java&p2=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/PoolingException.java&r1=18348&r2=18349
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/PoolingException.java (original)
> +++ trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/PoolingException.java 2008-02-29 09:37:11+0000
> @@ -41,7 +41,7 @@
> * Use is subject to license terms.
> *
> */
> -package com.sun.enterprise.resource.pool;
> +package com.sun.appserv.connectors.spi;
>
> import java.io.PrintStream;
> import java.io.PrintWriter;
>
> Modified: trunk/v3/common/glassfish-api/src/main/java/com/sun/
> appserv/connectors/spi/ResourceHandle.java
> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/ResourceHandle.java?view=diff&rev=18349&p1=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/ResourceHandle.java&p2=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/ResourceHandle.java&r1=18348&r2=18349
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/ResourceHandle.java (original)
> +++ trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/ResourceHandle.java 2008-02-29 09:37:11+0000
> @@ -33,24 +33,23 @@
> * only if the new code is made subject to such option by the
> copyright
> * holder.
> */
> -package com.sun.enterprise.container.common.spi;
> +package com.sun.appserv.connectors.spi;
>
> -import javax.resource.spi.ConnectionEventListener;
> -import javax.security.auth.Subject;
> import javax.transaction.xa.XAResource;
>
> -import org.jvnet.hk2.annotations.Contract;
> +import com.sun.appserv.connectors.spi.PoolingException;
>
> /**
> * ResourceHandle interface to be used by transaction manager
> components
> *
> * @author Marina Vatkina
> */
> -_at_Contract
> +
> public interface ResourceHandle {
>
> public boolean isTransactional();
>
> + //TODO V3 not needed as of now.
> public boolean isEnlistmentSuspended();
>
> public XAResource getXAResource();
> @@ -61,7 +60,7 @@
>
> public void setComponentInstance(Object instance);
>
> - public void closeUserConnection();
> + public void closeUserConnection() throws PoolingException;
>
> public boolean isEnlisted();
>
>
> Modified: trunk/v3/common/glassfish-api/src/main/java/com/sun/
> appserv/connectors/spi/TransactedPoolManager.java
> Url: https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/TransactedPoolManager.java?view=diff&rev=18349&p1=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/TransactedPoolManager.java&p2=trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/connectors/spi/TransactedPoolManager.java&r1=18348&r2=18349
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/TransactedPoolManager.java (original)
> +++ trunk/v3/common/glassfish-api/src/main/java/com/sun/appserv/
> connectors/spi/TransactedPoolManager.java 2008-02-29 09:37:11+0000
> @@ -33,19 +33,20 @@
> * only if the new code is made subject to such option by the
> copyright
> * holder.
> */
> -package com.sun.enterprise.container.common.spi;
> +package com.sun.appserv.connectors.spi;
>
> import org.jvnet.hk2.annotations.Contract;
>
> import javax.transaction.Transaction;
>
> +import com.sun.appserv.connectors.spi.ResourceHandle;
> +
> /**
> - * PoolManager manages jdbc and connector connection pool
> + * TransactedPoolManager manages jdbc and connector connection pool
> */
> @Contract
> -public interface PoolManager {
> +public interface TransactedPoolManager {
>
> void resourceEnlisted(Transaction tran, ResourceHandle res)
> throws IllegalStateException;
> -
> }
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe_at_glassfish-svn.dev.java.net
> For additional commands, e-mail: commits-help_at_glassfish-svn.dev.java.net
>