Peter Williams wrote On 01/30/07 10:26 AM,:
> Kin-man Chung wrote:
>
>> I've just committed the fix.
>>
>> On Mon, 2007-01-29 at 19:56, ludo wrote:
>>
>>
>>> Kin-man Chung wrote:
>>>
>>>> This is indeed a bug with Jasper, introduced when I put in
>>>> support for Jsr199 last year (August). Looks like nobody has been
>>>> debugging JSP?
>>>>
>>>>
>>>
>>> So we do not have regression tests there? A bit scary...Can you add
>>> one with your integration?
>>>
>>
>>
>> Well, a JSP compiled without line info still runs perfectly, so it's not
>> caught by the tests we have. I think I can use javap to see if line
>> numbers have been generated, but I still don't know if the JSP line to
>> Java line mapping was generated correctly.
>>
>>
>>
>>> Also why did we change the property names in sun-web.xml? Why can't we
>>> keep the exact same ones as in GF v1?
>>> Unless the old properties still work with your new fix?
>>>
>>>
>>
>> A new property was added to better support Jsr199, the others still work
>> as before.
>>
>
> What is this property and where can I find it documented?
The property's name is "saveBytecode".
It is documented in the domain's default-web.xml, and will be added
to the table of <jsp-config> properties in sun-web.xml in the "Application
Deployment Guide" for 9.1 beta (review comments already sent to June Parks),
as follows:
Property: saveBytecode
Default: false, true for jspc
Description: Should generated byte code be saved to .class files?
This option is meaningful only when the Java compiler API, JSR 199
(available with, and used as the default on Java 6) is used for javac
compilations.
Jan
>
> -Peter
>
>> -Kin-man
>>
>>
>>
>>> I would not want to tell developers to change these in order to debug
>>> jsps...
>>>
>>> Ludo
>>>
>>>
>>>> The fix is trivial, and I'll commit one tomorrow. Thanks Vince,
>>>> for reporting. :-)
>>>>
>>>> -Kin-man
>>>>
>>>> On Mon, 2007-01-29 at 18:08, Ludovic Champenois wrote:
>>>>
>>>>
>>>>> Vince Kraemer wrote:
>>>>>
>>>>>
>>>>> Does it still work with nb5.5.1 daily and GlassFish V1? Just want
>>>>> to make sure this is a GF V2 issue...
>>>>>
>>>>> Ludo
>>>>>
>>>>>
>>>>>> Kin-man Chung wrote:
>>>>>>
>>>>>>
>>>>>>> On Mon, 2007-01-29 at 17:01, Vince Kraemer wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Kin-man Chung wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Are you using JDK6?
>>>>>>>>
>>>>>>>> no.. I am using 5_10
>>>>>>>>
>>>>>>>
>>>>>>> Hmm.. Then it should have worked.
>>>>>>
>>>>>> I agree.
>>>>>>
>>>>>>
>>>>>>> To debug JSP pages,
>>>>>>> javac compilations should be invoked with a "-g" (which you
>>>>>>> did with "classdebuginfo" property), and SMAP info should be
>>>>>>> generated with the bytecodes (controlled by "suppressSmap",
>>>>>>> defaulted to false).
>>>>>>>
>>>>>>> How did the JSP page got compiled?
>>>>>>
>>>>>> When i access the index.jsp from the browser.
>>>>>>
>>>>>>
>>>>>>> By netbeans, precompiled
>>>>>>> when deployed, or dynamically? Can you make sure that it is
>>>>>>> done dynamically?
>>>>>>>
>>>>>>
>>>>>> it is being done dynamically.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> If you are, try setting the following properties in
>>>>>>>>> <jsp-config>
>>>>>>>>>
>>>>>>>>> keepgenerated: true
>>>>>>>>> saveByteCode: true
>>>>>>>>>
>>>>>>>>> I have asked Netbeans to set them as defaults in JDK 6.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Where did you make this request?
>>>>>>>>
>>>>>>>
>>>>>>> Petr Pisi was in Santa Clara last week. We talked about
>>>>>>> NetBeans support for JSP, including running with JDK 6.
>>>>>>>
>>>>>>> -Kin-man
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>