dev@glassfish.java.net

Re: CODE REVIEW: bug #1653

From: kedar <Kedar.Mhaswade_at_Sun.COM>
Date: Mon, 11 Dec 2006 11:39:43 -0800

This is admin code.
Can you kindly use admin_at_glassfish alias?

Also, please send cvs diff -u to put stuff
in context.

Kedar


Lloyd L Chambers wrote:
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1653 "Eliminate
> code in AdminService that registers "foo" MBeans"
>
> Index:
> appserv-core/src/java/com/sun/enterprise/admin/server/core/AdminService.java
>
> ===================================================================
> RCS file:
> /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/AdminService.java,v
>
> retrieving revision 1.14
> diff -r1.14 AdminService.java
> 387d386
> < registerJVMMonitoringMBeans();
> 886,891d884
> < if (isDas()) {
> < //register SystemService MBean under the old 8.0
> name as well
> < //to backward compatibility with 8.0 RI client -
> hardcoded
> < mbs.registerMBean(impl, new
> ObjectName("ias:type=system-services"));
> < sLogger.finer("Admin Message: System Services MBean
> Registered with sibling name: " + on.toString());
> < }
> 974,987d966
> < }
> < private void registerJVMMonitoringMBeans() {
> < try {
> < //register the thread-dump related MBeans
> < final ObjectName dummy1 = new
> ObjectName("foo:bar=bar1"), dummy2 = new ObjectName("foo:bar=bar2");
> < if (this.isDas()) {
> < final Object jvmic =
> Class.forName("com.sun.enterprise.admin.mbeans.jvm.JVMInformationCollector").newInstance();
>
> <
> com.sun.enterprise.admin.common.MBeanServerFactory.getMBeanServer().registerMBean(jvmic,
> dummy1);
> < }
> < final Object jvmi =
> Class.forName("com.sun.enterprise.admin.mbeans.jvm.JVMInformation").newInstance();
>
> <
> com.sun.enterprise.admin.common.MBeanServerFactory.getMBeanServer().registerMBean(jvmi,
> dummy2);
> < } catch (final Exception e) {
> < e.printStackTrace();
> < }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>