Ok Michael, comments inline..
Michael Bouschen wrote:
> Hi Dinesh,
>
> thanks for the feedback. Please find my comments below.
>
>> Hi Michael, comments below.
>>
>> Michael Bouschen wrote:
>>
>>> Hi Dinesh,
>>>
>>> thanks!
>>>
>>> I still have problems with the FCS branch, but maybe I misunderstood
>>> the process. I noticed the branch build instructions do not mention
>>> 'maven bootstrap'. Does this mean 'maven bootstrap' is not supported
>>> on the branch, such that I need to checkout all the source in order
>>> to build?
>>>
>>> I tried 'maven bootstrap' and it could not find the image to
>>> download (see details below).
>>
>>
>> I checked in the changes after testing yesterday, did you update
>> glassfish/bootstrap module? since I updated
>> glassfish/bootstrap/project.properties to download SNAPSHOT image
>> from new location:
>> *http://download.java.net/javaee5/fcs_branch/nightly/${glassfish.os.name}*
>>
>
>
> Yes, I have updated my workspace. I tried it again and now it works.
> There must have been a problem accessing the new location when I tried
> it a couple of hours ago. Sorry for the confusion.
>
> [...]
>
>>
>>> Another question:
>>> it tries to find an image called glassfish-image-SNAPSHOT.jar which
>>> has the same name as the image downloaded by 'maven bootstrap' in
>>> the trunk. Maven stores both images in the same local maven
>>> repository. So the branch image would overwrite the trunk image,
>>> unless we are using different groupids for branch and trunk. This
>>> implies I cannot have both: a FCS workspace and a trunk workspace on
>>> the same machine.
>>
>>
>> No that's not true, currently we have following locations for
>> SNAPSHOT jar files.
>> SJSAS90_FCS_BRANCH:
>> http://download.java.net/javee5/fcs_branch/nightly/${glassfish.os.name}
>> TRUNK:
>> http://download.java.net/javaee5/trunk/nightly*/*${glassfish.os.name}
>
>
> These are the maven remote maven repositories and you are right we
> have different locations for theses. But this is not what I meant. I
> am talking about my *local* maven repository (property
> maven.repo.local). Calling 'maven bootstrap' will update
> glassfish-image-SNAPSHOT.jar in
> ~/.maven/repository/glassfish-image/jars on my computer. Both branch
> and trunk use the same file under the same location.
Yes, it would be the case if you have "maven.repo.local" variable
defined in your $HOME/build.properties otherwise (if you don't have it
defined as per build instructions
<
https://glassfish.dev.java.net/public/BuildGlassFish.html>) default
value would be
maven.repo.local=${glassfish.root}/glassfish_dependencies
And the above value is relative path to the workspace,
glassfish.root=${basedir}/../.. Branch and trunk builds will have
different directories which don't conflict as against to what you are
describing. So just use default values and the problem you are facing
won't arise.
thanks
Dinesh
>
> Suppose I first call 'maven bootstrap' in my FCS workspace. This
> downloads the image and unzips it. Then I change to my trunk workspace
> and call 'maven bootstrap there. Now, this should download the "trunk"
> version of the image. But since maven finds a current version in the
> maven local repository, it takes this one and unzips the wrong
> version. I think maven is doing fine here. The issue is that we give
> two different images the same name in the maven dependencies.
>
> Regards Michael
>
>>
>> I updated both the branches, so you update or get the new workspace
>> and try this, as on existing ones it may not have latest changes.
>> thanks
>> Dinesh
>>
>>> Here is the output from calling 'maven bootstrap' on the branch:
>>>
>>> % maven -b bootstrap
>>> Starting the reactor...
>>> Our processing order:
>>> glassfish
>>> +----------------------------------------
>>> | Downloading SNAPSHOT jar files now glassfish
>>> | Memory: 3M/4M
>>> +----------------------------------------
>>> Attempting to download glassfish-image-SNAPSHOT.jar.
>>> WARNING: Failed to download glassfish-image-SNAPSHOT.jar.
>>>
>>> BUILD FAILED
>>> File...... d:\sjsas9\FCS\glassfish\bootstrap\maven.xml
>>> Element... maven:reactor
>>> Line...... 50
>>> Column.... 40
>>> The build cannot continue because of the following unsatisfied
>>> dependency:
>>>
>>> glassfish-image-SNAPSHOT.jar
>>>
>>> Regads Michael
>>>
>>>> I just integrated this change, so just follow the instructions
>>>> <https://glassfish.dev.java.net/public/BuildGlassFish.html#Branch>
>>>> to checkout glassfish/bootstrap module from SJSAS90_FCS_BRANCH and
>>>> bootstrap will download FCS snapshot image from
>>>> http://download.java.net/javee5/fcs_branch/nightly location now.
>>>> thanks
>>>> Dinesh
>>>>
>>>> Dinesh Patil wrote:
>>>>
>>>>> Michael, yes we have plan to do this.. Looks like staging is done
>>>>> now, will test it and update the workspace for FCS branch today.
>>>>> thanks
>>>>> Dinesh
>>>>>
>>>>> Michael Bouschen wrote:
>>>>>
>>>>>> Hi Dinesh,
>>>>>>
>>>>>> calling 'maven bootstrap' in a SJSAS90_FCS_BRANCH bootstrap
>>>>>> directory downloads the glassfish SNAPSHOT image:
>>>>>> Attempting to download glassfish-image-SNAPSHOT.jar.
>>>>>>
>>>>>> Are there any plans to change the dependency in the FCS branch to
>>>>>> refer to a FCS build instead of the SNAPSHOT?
>>>>>>
>>>>>> Regards Michael
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>