dev@glassfish.java.net

Re: CVS update: /glassfish/entity-persistence/

From: Dinesh Patil <dinesh.patil_at_Sun.COM>
Date: Tue, 18 Oct 2005 12:58:09 -0700

Tom,

We don't see the Reviewer and Tests/Build ran for this and other
checkins that you are having.. So please follow the commit
procedures: https://glassfish.dev.java.net/public/
GuidelinesandConventions.html#Commit_Procedures

Currently build seems to be broken, please take a look at it..

thanks
Dinesh

On Oct 18, 2005, at 12:42 PM, tware_at_dev.java.net wrote:

> User: tware
> Date: 2005/10/18 12:42:29
>
> Log:
> Issue number:
> Obtained from:
> Submitted by:
> Reviewed by:
> CVS:
> ----------------------------------------------------------------------
> CVS: Issue number:
> CVS: If this change addresses one or more issues,
> CVS: then enter the issue number(s) here.
> CVS: Obtained from:
> CVS: If this change has been taken from another system,
> CVS: then name the system in this line, otherwise delete it.
> CVS: Submitted by:
> CVS: If this code has been contributed to the project by someone
> else; i.e.,
> CVS: they sent us a patch or a set of diffs, then include their
> name/email
> CVS: address here. If this is your work then delete this line.
> CVS: Reviewed by:
> CVS: If we are doing pre-commit code reviews and someone else has
> CVS: reviewed your changes, include their name(s) here.
> CVS: If you have not had it reviewed then delete this line.
>
> File Changes:
>
> Directory: /glassfish/entity-persistence/
> =========================================
>
> File [changed]: build.xml
> Url: https://glassfish.dev.java.net/source/browse/glassfish/entity-
> persistence/build.xml?r1=1.3&r2=1.4
> Delta lines: +2 -2
> -------------------
> --- build.xml 12 Oct 2005 23:05:38 -0000 1.3
> +++ build.xml 18 Oct 2005 19:42:26 -0000 1.4
> @@ -33,8 +33,8 @@
> <property file="./build.properties"/>
>
> <property file="${user.home}/build.properties"/>
> - <property file="${glassfish.maven}/project.properties"/>
> - <property file="${glassfish.maven}/glassfish.properties"/>
> + <property file="${basedir}/../bootstrap/project.properties"/>
> + <property file="${basedir}/../bootstrap/glassfish.properties"/>
>
> <property name="query.antlr.dir"
> location="src/java/oracle/toplink/essentials/
> internal/parsing/ejbql/antlr273"/>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cvs-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: cvs-help_at_glassfish.dev.java.net
>
>