admin@glassfish.java.net

Re: server names

From: Joe Di Pol <joe.dipol_at_oracle.com>
Date: Thu, 09 Dec 2010 09:26:34 -0800

Tom Mueller wrote:
> Also, I wonder if configs should also use NAME_SERVER_REGEX because the
> name of the config is used in a directory name on the "config" directory.

I vote for more restrictive rather than less (unless we have a compatibility
issue). So I say yes.

Joe

>
> Tom
>
>
> On 12/9/2010 10:55 AM, Joe Di Pol wrote:
>>
>> For Nodes I just copied and pasted from some place else. I honestly
>> thought they were all the same. My intent was that nodes would be
>> the same as server instances.
>>
>> I would vote for being more consistent and restrictive -- unless
>> there is a compatibility reason to match what is in 2.1
>>
>> Tom Mueller wrote:
>>> While going through the @Pattern annotations in the config beans
>>> today, I noticed the following detail:
>>>
>>> The server regex is:
>>>
>>> "[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\.;]*"
>>>
>>> while the regex for all of the names (except for apps) is:
>>>
>>> "[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\./;#]*"
>>>
>>> The difference between this is that "/" and "#" is not allowed in a
>>> server name.
>>>
>>> I expect that the "/" is disallowed because the server name is used
>>> as a filename under the "nodes" directory. Is there a reason why "#"
>>> is excluded?
>>>
>>> Just checking to make sure this was intentional.
>>>
>>> Thanks.
>>> Tom
>>>
>>>
>>