admin@glassfish.java.net

Re: server names

From: Tom Mueller <tom.mueller_at_oracle.com>
Date: Thu, 09 Dec 2010 10:59:58 -0600

  Nodes are using the name one, so # and / are allowed currently.
Currently there are three of these regex's in the code:

     public static final String NAME_REGEX =
"[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\./;#]*";
     public static final String NAME_SERVER_REGEX =
"[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\.;]*";
     public static final String NAME_APP_REGEX =
"[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\./;:#]*";

I'm putting these in a Constants class and giving them names.
I'll change the node ones to NAME_SERVER_REGEX.

Tom


On 12/9/2010 10:55 AM, Joe Di Pol wrote:
>
> For Nodes I just copied and pasted from some place else. I honestly
> thought they were all the same. My intent was that nodes would be
> the same as server instances.
>
> I would vote for being more consistent and restrictive -- unless
> there is a compatibility reason to match what is in 2.1
>
> Tom Mueller wrote:
>> While going through the @Pattern annotations in the config beans
>> today, I noticed the following detail:
>>
>> The server regex is:
>>
>> "[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\.;]*"
>>
>> while the regex for all of the names (except for apps) is:
>>
>> "[\\p{L}\\p{N}_][\\p{L}\\p{N}\\-_\\./;#]*"
>>
>> The difference between this is that "/" and "#" is not allowed in a
>> server name.
>>
>> I expect that the "/" is disallowed because the server name is used
>> as a filename under the "nodes" directory. Is there a reason why "#"
>> is excluded?
>>
>> Just checking to make sure this was intentional.
>>
>> Thanks.
>> Tom
>>
>>
>