The command where the status reflects is list-domains.
It should show "<domain-name> restart required" when that domain
needs a restart.
Sorry, this is the ball I've dropped and Bill seems to have picked
it up. Thanks Bill.
We should do what v2 did in this regard.
-Kedar
Lloyd Chambers wrote:
> Bill,
>
> We can certainly provide a boolean method.
>
> Can it simply be one more status information instead of another command?
> Might there be other useful goodies:
>
> asadmin status
>
> ?
>
>
> On Oct 30, 2009, at 11:16 AM, Bill Shannon wrote:
>
>> I don't much care how the data is provided internally. I'll let you
>> guys decide the best way to do that. The code AMX was using seemed
>> simple enough, although a bit indirect (and I don't understand at all
>> how it actually *worked*).
>>
>> AMX seems to want the list of pending changes. All I need is a boolean -
>> "are there any pending changes?", aka "is restart required?"
>>
>> What I need to figure out is the best way to expose that through an
>> asadmin command...
>>
>> "__restart-required", where the command succeeds if restart is required
>> and fails if not?
>>
>> "get-restart-required", where the command returns "true" or "false"?
>>
>>
>>
>> Jerome Dochez wrote on 10/30/09 10:49:
>>> we will see if Bill wants it. no need to do anything extra if not
>>> needed.
>>> On Oct 30, 2009, at 10:24 AM, Lloyd Chambers wrote:
>>>> OK, but do you want me to relocate the *implementation* code to
>>>> another module?
>>>>
>>>>
>>>> On Oct 30, 2009, at 9:46 AM, Jerome Dochez wrote:
>>>>
>>>>> it would most likely be a glassfish-api contract or worse case an
>>>>> internal-api contract.
>>>>>
>>>>> jerome
>>>>>
>>>>> On Oct 30, 2009, at 9:41 AM, Lloyd Chambers wrote:
>>>>>
>>>>>> That's fine, where to locate it?
>>>>>>
>>>>>> On Oct 30, 2009, at 9:36 AM, Jerome Dochez wrote:
>>>>>>
>>>>>>>
>>>>>>> On Oct 29, 2009, at 2:19 PM, Bill Shannon wrote:
>>>>>>>
>>>>>>>> So it sounds like the answer is "no one else is doing this".
>>>>>>>>
>>>>>>>> I don't completely understand how the AMX code works. If
>>>>>>>> UnprocessedConfigListener.getUnprocessedChangeEvents() returns
>>>>>>>> a non-empty list, does that mean that restart is required?
>>>>>>>>
>>>>>>>> UnprocessedConfigListener is in the org.glassfish.admin.mbeanserver
>>>>>>>> package. Does that mean it depends on the MBean server? Is there
>>>>>>>> a way to get this information that doesn't depend on the MBean
>>>>>>>> server?
>>>>>>> we could have a small service that listen to changes notification
>>>>>>> and keep the unprocessed ones for public consumption.
>>>>>>> AMX could start using that service too.
>>>>>>>
>>>>>>> simple enough to do, u want it ?
>>>>>>>
>>>>>>> jerome
>>>>>>>
>>>>>>>>
>>>>>>>> Lloyd Chambers wrote:
>>>>>>>>> Bill,
>>>>>>>>> Look at the code that AMX uses.
>>>>>>>>> Lloyd
>>>>>>>>> On Oct 29, 2009, at 1:51 PM, Bill Shannon wrote:
>>>>>>>>>> Right, but asadmin doesn't use AMX. Is anyone working on
>>>>>>>>>> exposing it
>>>>>>>>>> through the http interface that asadmin uses? Is there a
>>>>>>>>>> "get" command
>>>>>>>>>> that will return the value?
>>>>>>>>>>
>>>>>>>>>> Lloyd Chambers wrote:
>>>>>>>>>>> It's already there for a long time in AMX.
>>>>>>>>>>> See org.glassfish.admin.amx.impl.ext.SystemStatusImpl
>>>>>>>>>>> Lloyd
>>>>>>>>>>> On Oct 29, 2009, at 10:59 AM, Bill Shannon wrote:
>>>>>>>>>>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=6132
>>>>>>>>>>>>
>>>>>>>>>>>> Is anyone working on adding a restart-required flag and/or
>>>>>>>>>>>> exposing it
>>>>>>>>>>>> through the admin interface so that the list-domains command
>>>>>>>>>>>> can display it?
>>>>>>>>>>>>
>>>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>> admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>> admin-help_at_glassfish.dev.java.net
>>>>>>>>>>>>
>>>>>>>>>>> Lloyd Chambers
>>>>>>>>>>> lloyd.chambers_at_sun.com
>>>>>>>>>>> GlassFish Team
>>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>> admin-help_at_glassfish.dev.java.net
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>> admin-help_at_glassfish.dev.java.net
>>>>>>>>>>
>>>>>>>>> Lloyd Chambers
>>>>>>>>> lloyd.chambers_at_sun.com
>>>>>>>>> GlassFish Team
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>> Lloyd Chambers
>>>>>> lloyd.chambers_at_sun.com
>>>>>> GlassFish Team
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> Lloyd Chambers
>>>> lloyd.chambers_at_sun.com
>>>> GlassFish Team
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> Lloyd Chambers
> lloyd.chambers_at_sun.com
> GlassFish Team
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>