admin@glassfish.java.net

Re: Review of create-connector-connection-pool man page

From: Jennifer Chou <Jennifer.Chou_at_Sun.COM>
Date: Fri, 30 Oct 2009 11:24:28 +0000

Dixie Pine wrote:
>
>
> On 10/28/09 10:56 AM, Jennifer Chou wrote:
>> Review for create-connector-connection-pool.
>>
>> 1)
>>
>>
>> Remove "Legal values are on, off, yes, no, 1,0, true or false". The
>> command only accepts true or false for failconnection.
> DONE.
> I also fixed the option mentioned, which seems to now be called
> --isconnectvalidatereq.
thanks - that's right.
>>
>> 2)
>>
>>
>> Default value is true.
> DONE
> I also changed the order to true|false in Synopsis.
> Question: In my current build, the usage message says false is
> default. I assume that has changed?
I guess you have an older build? Mine says says true is default.

C:\fishfry\v3\distributions\glassfish\target\glassfishv3\glassfish\bin>asadmin
create-connector-connection-pool --usage
Invalid option: --usage
Usage: asadmin [asadmin-utility-options]
create-connector-connection-pool --raname <raname>
--connectiondefinition <connectiondefinition> [--steadypoolsize
<steadypoolsize>] [--maxpoolsize <maxpoolsize>] [--maxwait <maxwait>]
[--poolresize<poolresize>] [--idletimeout <idletimeout>]
[--isconnectvalidatereq=false] [--failconnection=false] [--leaktimeout
<leaktimeout>] [--leakreclaim=false] [--creationretryattempts
<creationretryattempts>] [--creationretryinterval
<creationretryinterval>] [--lazyconnectionenlistment=false]
[--lazyconnectionassociation=fals
e] [--associatewiththread=false] [--matchconnections=true]
[--maxconnectionusagecount <maxconnectionusagecount>]
[--validateatmostonceperiod <validateatmostonceperiod>]
[--transactionsupport <transactionsupport>] [--description
<description>] [--property <property>] [--target <target>]
[-?|--help=false] poolname
Command create-connector-connection-pool failed.

>>
>> 3) You may want to add more to Description. I found more info in
>> the dtd.
>>
>> connector-connection-pool defines configuration used to create
>> and manage a pool of connections to a EIS. Pool definition is
>> named, and can be referred to by multiple connector-resource
>> elements (See connector-resource).
>>
>> Each named pool definition results in a pool instantiated at
>> server
>> start-up. Pool is populated when accessed for the first time. If
>> two or
>> more connector-resource elements point to the
>> same
>> connector-connection-pool element, they are using the same pool
>> of
>> connections, at run
>> time.
>>
>> There can be more than one pool for one connection-definition in
>> one
>>
>> resource-adapter.
>>
>>
> Cool. I edited this down. Please be sure I haven't changed some of the
> meaning. Tell me
> if anything should be removed for a man page.
Thanks - I think it looks good.

>> 4)
>>
>>
>>
>> I was looking here http://docs.sun.com/app/docs/doc/820-4916/aeoop?a=view
>> and it says default is 1. Not sure which one is correct. Maybe
>> Jagadish will know.
> Changed to this:
>
> Specifies the number of times the client runtime iterates through the
> address list in an effort to establish (or reestablish) a
> connection. Default
> value is 1.
>
> Jagadish will correct me if this is wrong. And if wrong, is the MQ doc
> wrong?
>
> Dixie
>>
>> Thanks,
>> Jennifer
>>
>> Dixie Pine wrote:
>>> Hi Jennifer,
>>>
>>> Here are the connector connection pool man pages for review. Also
>>> ping-connection-pool.
>>>
>>> thanks,
>>> Dixie
>>>
>>