HI Kedar,
I've applied your review and I have questions.
?? On the CLI, --user shows up a subcommand option so I included it in
the examples. Then I got a deprecated message when I ran a command with
--user in it, which I think means that --user should not be in the
subcommand syntax. Should I remove --user from the synopsis and options
list in the man page?
On 10/14/09 17:15, Kedar Mhaswade wrote:
> Dixie Pine wrote:
>> Hi Kedar,
>>
>> You are listed as owner on these man pages. Please review quickly so
>> I can get any fixes in for hard code freeze. Our deadline is friday
>> Oct. 9
>>
>> * create-domain has a new option: checkports.
>>
>> * Question on delete-domain. Is this really the syntax:
>>
>> Usage: asadmin [asadmin-utility-options] delete-domain [--domaindir
>> <domaindir>] *[--terse=false] [--ec ho=false]* [-?|--help=false]
>> domain_name
>> (from the CLI in build 66)
>
> Yes, same as v2.
?? And this seems wrong for v3. Should terse and echo really be
subcommand options for any subcommand in v3? No other local commands
have them.
>>
>> Usually --terse and --echo are strictly asadmin utility options. But
>> from this syntax, they are also subcommand options. This looks like a
>> mistake on engineering end. However, if they are really subcommand
>> options I can add them into the delete-domain man page. If so, these
>> options probably need some additional explanation as to how they
>> relate to the delete-domain subcommand.
>>
>> thanks,
>> Dixie
>
> create-domain:
> 1- Please redo the examples.
DONE
> 2- Please explain the authentication and the no-password admin user as
> described by Bill (a while ago).
??Any idea how to find this? Was it in an email? I'm not sure I would
recognize it...
> 3- Replace (--profile developer | cluster | enterprise) by --profile
> profile-name. (Anyway, the option is silently ignored).
A number of the options say "don't use this option..." and the
description is hidden. If you want me to restore any of those
descriptions because the option is now in use for v3, let me know.
Otherwise, I leave then as they were for Prelude.
> 4- Add somewhere:
> The create-domain process can be customized in that if there are
> domain customizers found in domain.xml, they are processed.
DONE
> (Get the details from Jerome, if needed).
> 5- Remove the statement "Either the --adminport option or the
> --portbase option must be specified." -- it's no more true.
DONE
> 6- Replace the paragraph:
>
> In addition to being an administrative boundary, a domain is also a
> fully compliant Java EE
> server. This means that you can deploy your Java EE applications to
> the domain and run them
> when the domain is started. A domain provides all the necessary
> environment and services
> essential to run the applications.
> with:
>
> A GlassFish v3 domain is a Java EE 6 compliant server. (The above
> paragraph is more for enterprise scenario where they need
> dedicated "admin servers").
DONE
>
> list-domains:
> 1- The default value for domains-dir is "generally" as-install/domains,
> but it can be different as well. It's decided by a variable
> AS_DEF_DOMAINS_PATH in install-dir/config/asenv.conf
I redid the create-domain Synopsis because it didn't match the CLI
command I ran. There are two additional options for which I need
descriptions as the options apply to create-domain:
-user --- I took a guess at this one -
-nopassword ---What do you want to say about this one?
Dixie