Jennifer,
This is an incompatible change and has to go through the CCC. Also
it might create a problem for domains created without any credentials.
If the domain doesn't require any authentication why would the database
do ?.
thanks
Sankar
Jennifer Chou wrote:
> Thanks Shalini for verifying it works for you.
>
> This change affects devtests, SQE, and documentation.
>
> Sankar - can you also let me know if it's ok to make this change.
>
> This is for fixing issue 6626 - Stop database command requires
> credentials when authentication is true
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=6626
>
> I've added --dbuser and --dbpassword to asadmin stop-database command.
>
> Attached is the cli-optional.jar you can test with.
>
> Thanks,
> Jennifer
>
>
> Shalini Muthukrishnan wrote:
>> Hi Jennifer,
>>
>> Jennifer Chou wrote:
>>> Shalini Muthukrishnan wrote:
>>>> Hi Jennifer,
>>>>
>>>> I see that you have added 2 new options : --dbuser and
>>>> --dbpassword. So when i start-database using asadmin start-database
>>>> command, only the user/password listed in the derby.properties file
>>>> under <install>/databases directory are allowed to stop-database
>>>> using command asadmin stop-database --dbuser APP --dbpassword APP.
>>>>
>>>> I have attached a derby.properties file with which i tested.
>>> I think you missed the attachment?
>>>> In this dbuser/dbpassword and APP are listed. So when i
>>>> start-database, i could either stop as APP or dbuser. So should
>>>> these options be added to the start-database command also?
>>> I thought the requirement is only for asadmin stop-database?
>> stop-database command works perfectly fine.
>>>>
>>>> Also, with these new attributes, what would be the implications on
>>>> other modules?
>>> I'm not sure - seem whoever is using asadmin stop-database would
>>> need to be updated.
>>>> How can this be used with the NetworkServerControl?
>>> If you are not using asadmin stop-database (which just calls
>>> NetworkServerControl), should you be able to use
>>> NetworkServerControl directly?
>> Sorry, there was a bug in my test case that was the reason for an
>> invalid authentication.
>>
>> If you wish to put in these changes, i will update the devtests
>> workspace with the tests that use derby authentication.
>>
>> Thanks a lot,
>> Shalini.
>>>
>>> Maybe I'm not clear on what the requirement is.
>>>
>>> Jennifer
>>>>
>>>> <target name="stop-derby">
>>>> <java classname="org.apache.derby.drda.NetworkServerControl"
>>>> classpath="${db.classpath}" failonerror="true"
>>>> fork="true">
>>>> <arg line="-h 0.0.0.0 -p 1527 -user ${derby.user}
>>>> -password ${derby.password} shutdown"/>
>>>> </java>
>>>> </target>
>>>>
>>>> The above will not work.
>>>>
>>>> Please help,
>>>> Thanks,
>>>> Shalini.
>>>>
>>>>
>>>> Jennifer Chou wrote:
>>>>> Can you see if this works for you?
>>>>>
>>>>> jen.jar contains the changed DerbyControl.java and
>>>>> StopDatabaseCommand.java in admin\cli-optional
>>>>> You can copy cli-optional.jar to modules directory.
>>>>>
>>>>> Shalini Muthukrishnan wrote:
>>>>>> Thank you.
>>>>>>
>>>>>> Jennifer Chou wrote:
>>>>>>> Thanks for reminding me. It looks like it only need to add
>>>>>>> --user and --password as required option in shutdown.
>>>>>>> I will try to send you something today to test with.
>>>>>>>
>>>>>>> Jennifer
>>>>>>>
>>>>>>> Shalini Muthukrishnan wrote:
>>>>>>>> Hi Jennifer,
>>>>>>>>
>>>>>>>> Sorry to bother you again on this one. When would this be
>>>>>>>> fixed? Some important tests are failing in jdbc because of this
>>>>>>>> one.
>>>>>>>>
>>>>>>>> Thanks in advance,
>>>>>>>> Shalini.
>>>>>>>>
>>>>>>>> Jennifer Chou wrote:
>>>>>>>>> Hi Shalini,
>>>>>>>>>
>>>>>>>>> Can it wait till after 7/13? I'm quite busy at the moment.
>>>>>>>>> Or if you're pressed, you may make the change and I can
>>>>>>>>> review? I can tell you where the code is.
>>>>>>>>>
>>>>>>>>> Jennifer
>>>>>>>>>
>>>>>>>>> Shalini Muthukrishnan wrote:
>>>>>>>>>> Hi Jennifer,
>>>>>>>>>>
>>>>>>>>>> Could i assign the issue 6626 to you? The stop-database
>>>>>>>>>> command needs to be fixed asap as this is affecting the
>>>>>>>>>> execution of some of the critical tests in jdbc.
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Shalini.
>>>>>>>>>
>>>>>>>
>>>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net