IMO, we should aggressively remove as much as we can that is not
consistent, or is undesirable for future support.
On Jun 29, 2009, at 5:25 PM, Bill Shannon wrote:
> Right now commands such as deploy accept the file to be deployed
> as either a command operand:
>
> $ asadmin deploy foo.war
>
> or as the value of a --path option:
>
> $ asadmin deploy --path foo.war
>
> On the server side, the operand is assigned to a field that's
> annotated as the "primary" field. In the deploy case, the name
> of this field is "path". I think it's an unintended side effect
> that --path is accepted as an option name. --path is not an option
> in v2.
>
> I'd like to remove support for these unintended options.
>
> This should have no impact on compatibility with v2, but it does mean
> that anyone using any of the early versions of v3 may have a
> compatibility
> issue if they've used this "feature".
>
> Unfortunately, the quicklook tests use this feature, suggesting that
> others may also have used it.
>
> What do people think?
>
> Should I remove this feature and revert to the v2 behavior (fixing
> quicklook,
> of course)?
>
> Or should I retain this feature?
>
> Not that this feature is *not* specific to the deploy commands,
> nor to the --path option. It causes the "primary" parameter
> for *any* command to also appear as a named option.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
Lloyd Chambers
lloyd.chambers_at_sun.com
GlassFish Team