Hi,
On Sreeram's request, I have cleaned up the following (GlassFish V2)
startup messages:
.....
[#|2008-03-26T22:08:23.924+0530|INFO|sun-comms-appserver1.0|javax.enterprise.system.stream.out|_ThreadID=10;_ThreadName=main;|/sailfin/mar26b/publish/glassfish/domains/domain1/config/.__com_sun_appserv_pid|#]
[#|2008-03-26T22:08:25.097+0530|INFO|sun-comms-appserver1.0|javax.enterprise.system.tools.admin|_ThreadID=10;_ThreadName=main;|ADM0001:SunoneInterceptor
is now enabled|#]
.....
[#|2008-03-26T22:08:25.923+0530|INFO|sun-comms-appserver1.0|javax.enterprise|_ThreadID=10;_ThreadName=main;|got
event0 event data: {}|#]
.....
[#|2008-03-26T22:08:27.513+0530|WARNING|sun-comms-appserver1.0|javax.enterprise.system.container.web|_ThreadID=10;_ThreadName=main;accesslog;_RequestID=af1c5d39-ef24-46df-8238-acc01caab408;|WEB0327:
Unsupported http-listener property (accesslog) is being ignored|#]
...
[#|2008-03-26T22:08:29.418+0530|INFO|sun-comms-appserver1.0|javax.enterprise.system.container.ejb|_ThreadID=10;_ThreadName=main;|EJBSCLookup::
sc.getEjbContainerAvailabilityEnabledFromConfig() ==> false|#]
...
[#|2008-03-26T22:08:45.408+0530|INFO|sun-comms-appserver1.0|javax.enterprise.resource.corba|_ThreadID=10;_ThreadName=main;|POARemoteRefFactory
checking if SFSBVersionPolicy need to be added|#]
[#|2008-03-26T22:08:45.409+0530|INFO|sun-comms-appserver1.0|javax.enterprise.system.container.ejb|_ThreadID=10;_ThreadName=main;|EJBSCLookup::
sc.getEjbContainerAvailabilityEnabledFromConfig() ==> false|#]
[#|2008-03-26T22:08:45.410+0530|INFO|sun-comms-appserver1.0|javax.enterprise.resource.corba|_ThreadID=10;_ThreadName=main;|POARemoteRefFactory
addSFSBVersionPolicy? false|#]
These messages will now be logged at FINE instead of at INFO level.
Please see the attached changes and let me know if you have any concerns.
Thanks,
-Yamini
Index: src/java/com/sun/appserv/server/LifecycleEventContextImpl.java
===================================================================
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/appserv/server/LifecycleEventContextImpl.java,v
retrieving revision 1.4
diff -u -r1.4 LifecycleEventContextImpl.java
--- src/java/com/sun/appserv/server/LifecycleEventContextImpl.java 5 May 2007 05:32:53 -0000 1.4
+++ src/java/com/sun/appserv/server/LifecycleEventContextImpl.java 25 Aug 2008 05:06:22 -0000
@@ -103,7 +103,7 @@
* message to be written to the log file
*/
public void log(String message) {
- logger.info(message);
+ logger.fine(message);
}
/**
@@ -118,6 +118,6 @@
* or exception
*/
public void log(String message, Throwable throwable) {
- logger.log(Level.INFO, message, throwable);
+ logger.log(Level.FINE, message, throwable);
}
}
Index: src/java/com/sun/ejb/base/sfsb/util/EJBServerConfigLookup.java
===================================================================
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/ejb/base/sfsb/util/EJBServerConfigLookup.java,v
retrieving revision 1.9
diff -u -r1.9 EJBServerConfigLookup.java
--- src/java/com/sun/ejb/base/sfsb/util/EJBServerConfigLookup.java 12 Jun 2007 18:02:37 -0000 1.9
+++ src/java/com/sun/ejb/base/sfsb/util/EJBServerConfigLookup.java 25 Aug 2008 05:06:22 -0000
@@ -721,9 +721,11 @@
isEJBAvailabilityEnabled = ejbSCLookup
.getEjbContainerAvailabilityEnabledFromConfig();
- _logger.log(Level.INFO,
+ if (_logger.isLoggable(Level.FINE)) {
+ _logger.log(Level.FINE,
"EJBSCLookup:: sc.getEjbContainerAvailabilityEnabledFromConfig() ==> "
+ isEJBAvailabilityEnabled);
+ }
try {
isClustered = ServerHelper.isServerClustered(configCtx,
@@ -736,17 +738,21 @@
isStoreTypeMemory = ejbSCLookup.isReplicationTypeMemory();
} catch (Exception ex) {
- _logger.log(Level.FINE,
+ if (_logger.isLoggable(Level.FINE)) {
+ _logger.log(Level.FINE,
"Got exception in needToAddSFSBVersionInterceptors ("
+ ex + "). SFSBVersionInterceptors not added");
- _logger.log(Level.FINE, "Exception in needToAddSFSBVersionInterceptors", ex);
+ _logger.log(Level.FINE, "Exception in needToAddSFSBVersionInterceptors", ex);
+ }
}
boolean result = isClustered && isEJBAvailabilityEnabled && isStoreTypeMemory;
- _logger.log(Level.FINE, "EJBServerConfigLookup::==> isClustered:"
+ if (_logger.isLoggable(Level.FINE)) {
+ _logger.log(Level.FINE, "EJBServerConfigLookup::==> isClustered:"
+ isClustered + " ; isEJBAvailabilityEnabled: "
+ isEJBAvailabilityEnabled + " ; isStoreTypeMemory ==> "
+ isStoreTypeMemory + " ; result: " + result);
+ }
// result = sc.getEjbContainerAvailabilityEnabledFromConfig();
return result;
Index: src/java/com/sun/enterprise/admin/server/core/AdminService.java
===================================================================
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/AdminService.java,v
retrieving revision 1.31.2.6
diff -u -r1.31.2.6 AdminService.java
--- src/java/com/sun/enterprise/admin/server/core/AdminService.java 12 Aug 2008 06:37:24 -0000 1.31.2.6
+++ src/java/com/sun/enterprise/admin/server/core/AdminService.java 25 Aug 2008 05:06:23 -0000
@@ -334,7 +334,9 @@
AMXLoggingHook.enableLoggingHook();
sunone.registerConfigMBeans();
- sLogger.log(Level.INFO, "core.sunone_interceptor_enabled");
+ if (sLogger.isLoggable(Level.FINE)) {
+ sLogger.log(Level.FINE, "core.sunone_interceptor_enabled");
+ }
initCallFlow();
//initialize JKS properties.
@@ -1106,8 +1108,10 @@
private void publishPID() {
JvmInfoUtil jvminfo = new JvmInfoUtil();
- System.out.println(System.getProperty("com.sun.aas.instanceRoot") +
+ if (sLogger.isLoggable(Level.FINE)) {
+ sLogger.log(Level.FINE, System.getProperty("com.sun.aas.instanceRoot") +
"/config/" + SystemPropertyConstants.PID_FILE);
+ }
jvminfo.logPID(System.getProperty("com.sun.aas.instanceRoot") +
File.separator + "config" + File.separator +
SystemPropertyConstants.PID_FILE);
Index: src/java/com/sun/enterprise/iiop/POARemoteReferenceFactory.java
===================================================================
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/iiop/POARemoteReferenceFactory.java,v
retrieving revision 1.17.6.1
diff -u -r1.17.6.1 POARemoteReferenceFactory.java
--- src/java/com/sun/enterprise/iiop/POARemoteReferenceFactory.java 11 Jun 2008 11:20:26 -0000 1.17.6.1
+++ src/java/com/sun/enterprise/iiop/POARemoteReferenceFactory.java 25 Aug 2008 05:06:23 -0000
@@ -179,7 +179,6 @@
+ " " + ejbDescriptor);
}
- logger.log(Level.INFO, "New POARemoteReferenceFactory created: " + container);
}
private String getRepositoryId(Class c) throws Exception {
@@ -301,13 +300,18 @@
}
}
- logger.log(Level.INFO, "POARemoteRefFactory checking if SFSBVersionPolicy need to be added");
+ if (logger.isLoggable(Level.FINE)) {
+ logger.log(Level.FINE, "POARemoteRefFactory checking if SFSBVersionPolicy need to be added");
+ }
+
/* Findbugs
EJBServerConfigLookup ejbConfigLookup =
new EJBServerConfigLookup(ejbDescriptor);
*/
boolean addSFSBVersionPolicy = EJBServerConfigLookup.needToAddSFSBVersionInterceptors();
- logger.log(Level.INFO, "POARemoteRefFactory addSFSBVersionPolicy? " + addSFSBVersionPolicy);
+ if (logger.isLoggable(Level.FINE)) {
+ logger.log(Level.FINE, "POARemoteRefFactory addSFSBVersionPolicy? " + addSFSBVersionPolicy);
+ }
if (addSFSBVersionPolicy) {
if (container instanceof StatefulSessionContainer) {
StatefulSessionContainer sfsbCon = (StatefulSessionContainer) container;
Index: src/java/com/sun/enterprise/web/PEWebContainer.java
===================================================================
RCS file: /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/web/PEWebContainer.java,v
retrieving revision 1.114.2.3
diff -u -r1.114.2.3 PEWebContainer.java
--- src/java/com/sun/enterprise/web/PEWebContainer.java 9 Jul 2008 17:33:18 -0000 1.114.2.3
+++ src/java/com/sun/enterprise/web/PEWebContainer.java 25 Aug 2008 05:06:24 -0000
@@ -963,13 +963,7 @@
String propName = httpListenerProps[i].getName();
String propValue = httpListenerProps[i].getValue();
try {
- if (!configureHttpListenerProperty(propName,
- propValue,
- connector)){
- _logger.log(Level.WARNING,
- "pewebcontainer.invalid_http_listener_property",
- propName);
- }
+ configureHttpListenerProperty(propName, propValue, connector);
} catch (NumberFormatException nfe) {
_logger.log(Level.WARNING,
"pewebcontainer.invalid_http_listener_property",