admin@glassfish.java.net

Refactored AdminConsoleAdapter (and InstallerThread)

From: Ken Paulsen <Ken.Paulsen_at_Sun.COM>
Date: Wed, 20 Aug 2008 20:53:59 -0700

Hi Kedar,

As we discussed on the phone, I have come up with a proposed refactoring
of the AdminConsoleAdapter.java file, which also impacted the
InstallerThread.java file. As we discussed I made a new file
(WebApplicationAdapter.java), however, if you think this approach is in
the right direction... I'd suggest sticking with the old name.

I have tested the code, it works. However, I know of 2 problems which
still need to be solved (but I didn't want to take the time to solve
them unless we're keeping this code):

1) I have a method "WebApplicationAdapter.hasPermission(...)" which
checks to see if the user has clicked the "OK" button. However, this
check will be forgotten after the server is shutdown. I want this to be
remembered. I was reluctant to check the existence of the "__admingui"
directory, but that may be one solution (the .war file may exist w/o an
acknowledgement as we ship with it in place -- so the .war is not an
option). I think I'd prefer a persistent flag instead.

2) The InstallerThread.install() method does not check to see if this
step has already been completed. This step will be executed every time
the server restarts, so it should check to see if it is needed first.
So, this code will add a new entry to the domain.xml after the server
starts everytime. This needs to be fixed.

Let me know what you think...

Thanks!

Ken