I agree, I think we should eliminate the property.
Another problem is that when the AMX DomainRoot is created, there
isn't necessarily a DomainConfig to get the property from.
One possibility is to have AMX get the config dir, then grab the
directory name from that, and (maybe) whack the property if it's
wrong. But of course if AMX is not started then that won't happen.
Lloyd
On Apr 3, 2008, at 11:17 AM, Kedar Mhaswade wrote:
> Lloyd L Chambers wrote:
>> What if config is:
>> /gf/domains/domain-foo/
>> and the property says "domain1"?
>
> That should never happen if you don't do something inconsistently.
>
> Frankly though, I don't like this property in domain.xml. It affects
> the relocatability of the domain. The easiest thing to do is name of
> the
> domain is the name of its folder.
>
> We should take this up after TP-2.
>
>> Lloyd
>> On Apr 3, 2008, at 11:02 AM, Byron Nevins wrote:
>>> The domain name is in domain.xml -- usually at the very bottom of
>>> the file --
>>>
>>> <property value="domain1" name="administrative.domain.name" />
>>> </domain>
>>>
>>>
>>> Lloyd L Chambers wrote:
>>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=4576
>>>>
>>>> How can I get the domain name? (And I hope there is not some
>>>> weird module dependency...)
>>>>
>>>> I presume that the domain name should be the name of the
>>>> directory eg "domain1".
>>>>
>>>> Lloyd
>>>>
>>>> ---
>>>> Lloyd L Chambers
>>>> lloyd.chambers_at_sun.com
>>>> Sun Microsystems, Inc
>>>>
>>>>
>>>>
>>>
>>> --
>>> Byron Nevins Work 408-276-4089, Home 650-359-1290, Cell
>>> 650-784-4123 - Sun Microsystems, Inc.
>>>
>> ---
>> Lloyd L Chambers
>> lloyd.chambers_at_sun.com
>> Sun Microsystems, Inc
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
---
Lloyd L Chambers
lloyd.chambers_at_sun.com
Sun Microsystems, Inc