admin@glassfish.java.net

Re: CODE REVIEW (LogMBean): minor bug fixes for 9.1.1 AMX unit test failures

From: Kedar Mhaswade <Kedar.Mhaswade_at_Sun.COM>
Date: Tue, 04 Dec 2007 16:53:47 -0800

Don't get me wrong, I do need to know what other *app server*
files appear there. AFAIK, server.log file(s), jvm.log and a folder
holding transaction logs (tx) are the only things that should
appear there.

And I admit the way you have coded it is better than my suggestion.
So, go ahead.

Lloyd L Chambers wrote:
> Kedar,
>
> Put it down as "I think I have seen other files appear there".
> Currently, all I end up seeing is jvm.log.
>
> Lloyd
>
> On Dec 4, 2007, at 4:34 PM, Kedar Mhaswade wrote:
>
>>
>>
>> Lloyd L Chambers wrote:
>>> Inline.
>>> On Dec 4, 2007, at 2:55 PM, Kedar Mhaswade wrote:
>>>>
>>>>
>>>> Lloyd L Chambers wrote:
>>>>> Diffs for fix at the source.
>>>>
>>>> Thank you, for doing it. I *really* appreciate that. It was not fine
>>>> masking it in AMX.
>>>>
>>>>> - had to make the prefix and suffix of the filename available so
>>>>> log files that match can be found. Now only files that start with
>>>>> "server" and end with ".log" will be returned as log file names.
>>>>
>>>> Ummm. That probably works. But how about returning all the files except
>>>> jvm.log. But that's just a thought. If this works, I am OK.
>>> Because I've seen other non-log files appear in that directory; the
>>> logic should be "return names of all server log files". That is what
>>> I've coded.
>> Really? Which ones? Under what circumstances?
>>
>> - Kedar
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---
> Lloyd L Chambers
> lloyd.chambers_at_sun.com
> Sun Microsystems, Inc
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>