admin@glassfish.java.net

Re: CODE REVIEW (LogMBean): minor bug fixes for 9.1.1 AMX unit test failures

From: Kedar Mhaswade <Kedar.Mhaswade_at_Sun.COM>
Date: Tue, 04 Dec 2007 16:34:10 -0800

Lloyd L Chambers wrote:
> Inline.
>
> On Dec 4, 2007, at 2:55 PM, Kedar Mhaswade wrote:
>
>>
>>
>> Lloyd L Chambers wrote:
>>> Diffs for fix at the source.
>>
>> Thank you, for doing it. I *really* appreciate that. It was not fine
>> masking it in AMX.
>>
>>> - had to make the prefix and suffix of the filename available so log
>>> files that match can be found. Now only files that start with
>>> "server" and end with ".log" will be returned as log file names.
>>
>> Ummm. That probably works. But how about returning all the files except
>> jvm.log. But that's just a thought. If this works, I am OK.
>
> Because I've seen other non-log files appear in that directory; the
> logic should be "return names of all server log files". That is what
> I've coded.
>
Really? Which ones? Under what circumstances?

- Kedar