admin@glassfish.java.net

Re: Code Review Request

From: Tim Quinn <Timothy.Quinn_at_Sun.COM>
Date: Sat, 03 Nov 2007 19:02:36 -0500

Hi, again.

Some further thoughts on this inserted below...

Rajeshwar V Patil wrote:
>>
>> As with Anissa's approach, all cases are handled using only one Java
>> code path (no need to choose among several possible messages) and only
>>
>> one message format.
>>
>>
> Previously, I thought of doing this but then opted to me more user friendly at the expense of more(complex) code.
>
I agree with the priorities but to me the difference in
user-friendliness between the several distinct messages approach vs.
Anissa's or my one message and one code path is rather small and the
increase in complexity is disproportionate to that gain.


>> 2. The original message used the phrase "...and {1} new *software*..."
>>
>> The term "software" is not normally a noun that is quantifiable. That
>>
>> is, people don't normally say "I installed two softwares onto my
>> system
>> today." Far more often people use "software" as a singular noun
>> referring to one or more programs, packages, etc., as in "Think of all
>>
>> the software Sun has produced this in its lifetime." Or as a modifier
>>
>> to some other noun, as in "I installed two software packages" or
>> "...two
>> software downloads." Or if it's clear, just leave out the word
>> "software" and use another noun that is quantifiable. ("I installed
>> two
>> downloads today.")
>>
>> So in my suggested replacement message above I've used "module"
>> instead
>> of "software."
>>
>>
> In UC we have tabs labeled, *Available Updates* and *Available Software*. In order to relate to those, we used the
> term software instead of module.
>
I agree that the terms should be consistent -- and also well-chosen. To
me, then, the second tab should be labeled "Available Modules" and the
messages refer to modules. Anyway I took the idea for the term "module"
from the keys in the messages you added and I think that works better
than "software" for the reasons I've described earlier.
>> 3. In my suggestion I removed the word "new" because would there ever
>> be
>> "old" updates or downloads available?
>>
>>
> Yes, we do have old updates and old software available. We are informing user only of *new* updates and *new* software available. In UC, new updates and new software are those updates and modules which user has never viewed before. Once user views them(by invoking UC), they become old and are never informed about. In UC, new updates and new software are marked with a *(star) icon.
>
Ah, I see. Thanks for the explanation.
 

- Tim