From: Ana Caballero <Ana.Caballero_at_Sun.COM>
Date: Mon, 01 Oct 2007 20:11:07 -0700

Hi Anissa,

This looks fine to me.

Ana

Anissa Lam wrote:

>
> Please review the changes needed to fix issue# 3714
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=3714>.
> There is another variable with the same name 'serverName' stored in
> the session. For the local variable of the page, we need to specify
> the scope, ie requestScope so that the value will not be coming from
> the session variable map.
> Also notice that 'server-name' is a required attribute for
> http-listener, so putting in the enforcement.
>
> thanks
> Anissa.
>
>
> cvs diff -u httpListener.incIndex: httpListener.inc
> ===================================================================
> RCS file:
> /cvs/glassfish/admin-gui/src/docroot/configuration/httpListener.inc,v
> retrieving revision 1.7.8.1
> diff -u -r1.7.8.1 httpListener.inc
> --- httpListener.inc 13 Sep 2007 14:53:11 -0000 1.7.8.1
> +++ httpListener.inc 2 Oct 2007 01:14:18 -0000
> @@ -53,7 +53,7 @@
> NetwkAddr="#{netwkAddr}"
> ListenerPort="#{listenerPort}"
> DefaultVirtServer="#{defaultVirtServer}"
> - ServerName="#{serverName}"
> + ServerName="#{requestScope.serverName}"
> Listener="#{listener}"
> security="#{security}"
> RedirectPort="#{redirectPort}"
> @@ -79,7 +79,7 @@
> NetwkAddr="#{netwkAddr}"
> ListenerPort="#{listenerPort}"
> DefaultVirtServer="#{defaultVirtServer}"
> - ServerName="#{serverName}"
> + ServerName="#{requestScope.serverName}"
> Listener="#{listener}"
> security="#{security}"
> RedirectPort="#{redirectPort}"
> @@ -151,7 +151,7 @@
> <sun:dropDown id="DefaultVirtServers"
> styleClass="require" selected="#{requestScope.defaultVirtServer}"
> items="$attribute{defaultVirtServers}" required="#{true}"/>
> </sun:property>
> <sun:property id="ServerNameProp" labelAlign="left"
> noWrap="#{true}" overlapLabel="#{false}"
> label="$resource{i18n.httpListeners.serverNameLabel}"
> helpText="$resource{i18n.httpListeners.serverNameHelp}" >
> - <sun:textField id="ServerName" columns="$int{20}"
> text="#{requestScope.serverName}" />
> + <sun:textField id="ServerName" columns="$int{20}"
> text="#{requestScope.serverName}" styleClass="require"
> required="#{true}" />
> </sun:property>
> </sun:propertySheetSection>
> <!-- Advanced Settings section -->
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net For
> additional commands, e-mail: admin-help_at_glassfish.dev.java.net