Re: Code Review: Bug fix for: 6505045 ...
Great! Thank you.
/Oleg
Kedar Mhaswade wrote:
> Oleg, the latter. More suitable solution.
>
> How can we solve this for 8.x in some form and not do it for 9.x.
>
> I must say however that it will come in as a patch.
>
> - Kedar
>
> Oleg Kostukovsky wrote:
>
>> Kedar,
>>
>> Does it mean that this will not be addressed in 9.x at all or there
>> will be different, more suitable for 9.x solution?
>>
>> /Oleg
>>
>> Kedar Mhaswade wrote:
>>
>>> Mark,
>>>
>>> The community in general does not like to fix this on 9.1 this way.
>>> It's only for older releases and Oleg/Kevin should decide what
>>> they want to do.
>>>
>>> I am not planning to check this fix in for 9.1 trunk/UR1.
>>>
>>> - Kedar
>>>
>>> PS - Can I trade some other bugs for UR1, instead? :)
>>>
>>> Mark A. Basler wrote:
>>>
>>>> Hi Guys,
>>>>
>>>> Has this issue been resolved?
>>>>
>>>> Does this need to go into Glassfish V2 update 1?
>>>>
>>>> Please let me know...
>>>>
>>>> Thanks - Mark
>>>>
>>>> Kedar Mhaswade wrote:
>>>>
>>>>>
>>>>>> Re-reading the original bug report, I think the right solution is
>>>>>> to simply refuse to even *attempt* to change domain.xml if we
>>>>>> cannot create a temporary backup file (a temporary backup file
>>>>>> has other safety benefits too).
>>>>>
>>>>>
>>>>>
>>>>> A question:
>>>>>
>>>>> Do you mean don't even attempt
>>>>> - to "actually write" the domain.xml to disk, or
>>>>> - to modify the memory that represents the domain.xml's contents,
>>>>>
>>>>> when you can't create the backup file?
>>>>>
>>>>>
>>>>>> Lloyd
>>>>>>
>>>>>> On Sep 20, 2007, at 5:50 PM, Kedar Mhaswade wrote:
>>>>>>
>>>>>>> Finally, I have been able to fix this problem (reasonably).
>>>>>>>
>>>>>>> All about it can be found at:
>>>>>>> http://wiki.glassfish.java.net/attach/GlassFishAdminReferences/6505045.html
>>>>>>>
>>>>>>>
>>>>>>> Please go through the background and code changes if you have
>>>>>>> time and let me
>>>>>>> know if you have any comments, by tomorrow 12.00 noon, pacific.
>>>>>>>
>>>>>>> I am planning to check this in then, on GlassFish trunk.
>>>>>>>
>>>>>>> Mark Basler: I leave it up to you to approve the fix for 9.1
>>>>>>> UR1. If you do
>>>>>>> want to do that, let me know and I can port the changes there.
>>>>>>>
>>>>>>> I have run the tests on my 128M Zip-drive on Mac OS X by
>>>>>>> observing domain.xml go
>>>>>>> to zero-bytes and domain.xml.protect coming to rescue, making
>>>>>>> every attempt
>>>>>>> to persist the domain.xml.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Kedar
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>
>>