Anissa,
Changes look good. You might have taken care of this already, just
checking anyway. How about required="true", or styleClass="required" in
the jsf/.inc file for server-name attribute, is this check removed now,
or it was not there earlier anyway for client side validation. Since we
allow empty string now, I'm assuming client side validation for this
field is removed.
thx
Senthil
Anissa Lam wrote:
> Please review the changes for fixing issue# 3714.
>
> This is different from the one i sent out yesterday as we don't want
> to force user to enter server-name for HTTP-Listener even though it is
> a required attribute. User should be able to leave the field empty,
> and default it to "" (empty string).
>
> - changes in httpListener.inc There is another variable with the
> same name 'serverName' stored in the session. For the local variable
> of the page, we need to specify the scope, ie requestScope so that
> the value will not be coming from the session variable map.
>
> - changes in JmxHandlers.java
> Pass an " " (with a space) to backend so that server-name will be
> writen out as "" empty string in domain.xml
>
> thanks
> Anissa
>
>