I'm sorry I did not dial in for the meeting. I accept any decision
made, though I think our users deserve data safety first.
On Sep 24, 2007, at 9:22 AM, Kedar Mhaswade wrote:
> OK. Now we need to have the vote.
>
> 1) It seems a different approach to resolve the problem and it
> reintroduces
> the backup file concept.
>
> 2) This bug fix is a patch without changing the notion of how we do
> config
> and does not reintroduce backup config file.
>
> Please let me know what we want to do 1) or 2).
>
> If we decide to do 1), Lloyd -- please create another bug/RFE that
> says so.
> If we decide to do 2), I will check in the code.
>
> Let's do this today.
>
> Prashanth -- can you take this up for the iteam meeting?
> Lloyd -- please make yourself available for the meeting.
>
> Thanks,
> Kedar
>
> Lloyd L Chambers wrote:
>> No changes to domain.xml should be allowed unless a backup file
>> exists.
>> Lloyd
>> On Sep 21, 2007, at 6:51 PM, Kedar Mhaswade wrote:
>>>
>>>> Re-reading the original bug report, I think the right solution
>>>> is to simply refuse to even *attempt* to change domain.xml if we
>>>> cannot create a temporary backup file (a temporary backup file
>>>> has other safety benefits too).
>>>
>>> A question:
>>>
>>> Do you mean don't even attempt
>>> - to "actually write" the domain.xml to disk, or
>>> - to modify the memory that represents the domain.xml's contents,
>>>
>>> when you can't create the backup file?
>>>
>>>
>>>> Lloyd
>>>> On Sep 20, 2007, at 5:50 PM, Kedar Mhaswade wrote:
>>>>> Finally, I have been able to fix this problem (reasonably).
>>>>>
>>>>> All about it can be found at:
>>>>> http://wiki.glassfish.java.net/attach/GlassFishAdminReferences/
>>>>> 6505045.html
>>>>>
>>>>> Please go through the background and code changes if you have
>>>>> time and let me
>>>>> know if you have any comments, by tomorrow 12.00 noon, pacific.
>>>>>
>>>>> I am planning to check this in then, on GlassFish trunk.
>>>>>
>>>>> Mark Basler: I leave it up to you to approve the fix for 9.1
>>>>> UR1. If you do
>>>>> want to do that, let me know and I can port the changes there.
>>>>>
>>>>> I have run the tests on my 128M Zip-drive on Mac OS X by
>>>>> observing domain.xml go
>>>>> to zero-bytes and domain.xml.protect coming to rescue, making
>>>>> every attempt
>>>>> to persist the domain.xml.
>>>>>
>>>>> Regards,
>>>>> Kedar
>>>>>
>>>>> ------------------------------------------------------------------
>>>>> ---
>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>
>>>> -------------------------------------------------------------------
>>>> --
>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>