I have received no feedback and will be committing this change at 16:30.
Lloyd
On Jul 27, 2007, at 1:35 PM, Lloyd L Chambers wrote:
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3405
>
> It appears that deleting the <server-ref> first is not needed.
>
> Index: src/java/com/sun/enterprise/management/config/
> ClusteredServerConfigFactory.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/mbeanapi-impl/src/java/com/sun/
> enterprise/management/config/ClusteredServerConfigFactory.java,v
> retrieving revision 1.7
> diff -w -u -r1.7 ClusteredServerConfigFactory.java
> --- src/java/com/sun/enterprise/management/config/
> ClusteredServerConfigFactory.java 5 May 2007 05:23:17
> -0000 1.7
> +++ src/java/com/sun/enterprise/management/config/
> ClusteredServerConfigFactory.java 27 Jul 2007 20:27:59 -0000
> @@ -167,9 +167,7 @@
> throw new IllegalArgumentException( "" +
> clusteredServerName );
> }
>
> - // found the ClusterConfig...remove its reference to
> this server
> - clusterConfig.removeServerRefConfig
> ( clusteredServerName );
> -
> + // removal of the <server-ref> is apparently implied...
> super.removeByName( clusteredServerName );
> }
> }
>
>