admin@glassfish.java.net

Re: CODE REVIEW: issue 3376

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Fri, 20 Jul 2007 15:26:39 -0700

Kedar,

     /**
      * sets the lb-enabled flag for the target, also sets the
disable-timeout-in-minutes
      * if the status flag is false.
      * @param target the cluster or the server for which the lb-
enabled has to be set
      * @param timeout The disable-timeout-in-minutes if the server
has to be disabled
      * @param status true to enable, false to disable the server
      * @param ignore false throw exception if the previous value is
same, true
      * otherwise
      */
     private void setServerStatus(String target, int timeout, boolean
status,
     boolean ignore) {


Lloyd

On Jul 20, 2007, at 3:22 PM, Kedar Mhaswade wrote:

> What does the last argument specify (which is left intact as "false")?
>
> Kedar
>
> Lloyd L Chambers wrote:
>> TIMEOUT: 12:00 PST Monday July 23
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=3376
>> Change 'false' to 'true' in call.
>> ===================================================================
>> RCS file: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
>> management/helper/LBConfigHelper.java,v retrieving revision 1.6
>> diff -w -u -r1.6 LBConfigHelper.java
>> --- src/java/com/sun/appserv/management/helper/
>> LBConfigHelper.java 5 Jun 2007 16:31:54 -0000 1.6
>> +++ src/java/com/sun/appserv/management/helper/
>> LBConfigHelper.java 20 Jul 2007 22:08:11 -0000
>> @@ -531,7 +531,7 @@
>> * @param target target server whose load balancing has to be
>> enabled
>> */
>> public void enableServer(String target) {
>> - setServerStatus(target, 0,false, false);
>> + setServerStatus(target, 0, true, false);
>> }
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>