I sent the changes for review.
On May 29, 2007, at 4:56 PM, kedar wrote:
>
>
> Lloyd L Chambers wrote:
>> Kedar,
>>
>> Thanks.
>>
>> I'm not sure of your view though, you say Absolutely", and "better
>> not to do it".
> It absolutely makes sense from the problem definition standpoint.
> It is better not do it from implementation standpoint.
>>
>> I'm trying go figure out what to do. Options seem to be:
>>
>> 1) remove the old get/set methods
>> 2) leave the old get/set methods, but throw an exception
>> 3) leave the old get/set methods, pass them through as before
>> 4) leave the old get/set methods, pass them through to the new names.
> I vote for 4. The old attributes were always wrong, I am told.
>>
>> Of the above, (1) and (2) are backward-incompatible.
>>
>> (3) works, but might be confusing.
>>
>> (4) has only minor drawbacks.
>>
>> Thoughts?
>>
>> Lloyd
>>
>> On May 29, 2007, at 4:37 PM, kedar wrote:
>>
>>>
>>>
>>> Lloyd L Chambers wrote:
>>>> Kedar,
>>>>
>>>> To determine how to proceed with AMX, I need to be clear on the
>>>> behavior--
>>>>
>>>> 1. Can the "old" attributes still be set (changed)?
>>> Yes, I think so.
>>>>
>>>> 2. Are the "old" attributes used at all?
>>> No, I don't think so.
>>>>
>>>> 3. Does it make sense to have AMX "patch through" the old names
>>>> to the new ones?
>>>>
>>> Absolutely. That means more work in AMX layer though. It's better
>>> not to do it. But it's your call.
>>>
>>> Kedar
>>>> Thanks,
>>>> Lloyd
>>>>
>>>> ----------------
>>>> Solution: Since we can't "remove" the attributes because that means
>>>> old XML can't validate against new DTD, we are deprecating these
>>>> attributes and introducing correctly named attributes as
>>>> optional ones.
>>>> We have done a similar thing with security-service element.
>>>> There is
>>>> no change in the semantics of the attributes, AFAIK.
>>>>
>>>> What is changing: The element http-protocol will be:
>>>> <!ATTLIST http-protocol
>>>> version CDATA "HTTP/1.1"
>>>> dns-lookup-enabled %boolean; "false"
>>>> forced-type CDATA "text/html; charset=iso-8859-1"
>>>> default-type CDATA "text/html; charset=iso-8859-1"
>>>> forced-response-type CDATA "AttributeIsDeprecated"
>>>> default-response-type CDATA "AttributeIsDeprecated"
>>>> ssl-enabled %boolean; "true">
>>>>
>>>> instead of:
>>>> <!ATTLIST http-protocol
>>>> version CDATA "HTTP/1.1"
>>>> dns-lookup-enabled %boolean; "false"
>>>> forced-response-type CDATA "text/html; charset=iso-8859-1"
>>>> default-response-type CDATA "text/html; charset=iso-8859-1"
>>>> ssl-enabled %boolean; "true">
>>>>
>>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>