admin@glassfish.java.net

CODE REVIEW: AMX HTTPProtocolConfig

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Fri, 25 May 2007 17:01:14 -0700

TIMEOUT: 12:00 PST Tuesday May 29

This change tracks a DTD change in a backward-compatible manner. See:
https://glassfish.dev.java.net/issues/show_bug.cgi?id=3072

diffs below.

Lloyd

RCS file: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
management/config/HTTPProtocolConfig.java,v
retrieving revision 1.2
diff -w -u -r1.2 HTTPProtocolConfig.java
--- src/java/com/sun/appserv/management/config/
HTTPProtocolConfig.java 5 May 2007 05:30:33 -0000 1.2
+++ src/java/com/sun/appserv/management/config/
HTTPProtocolConfig.java 25 May 2007 23:58:47 -0000
@@ -33,14 +33,6 @@
   * only if the new code is made subject to such option by the
copyright
   * holder.
   */
-
-/*
-* $Header: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
management/config/HTTPProtocolConfig.java,v 1.2 2007/05/05 05:30:33
tcfujii Exp $
-* $Revision: 1.2 $
-* $Date: 2007/05/05 05:30:33 $
-*/
-
-
package com.sun.appserv.management.config;
import com.sun.appserv.management.base.XTypes;
@@ -54,26 +46,48 @@
/** The j2eeType as returned by {_at_link
com.sun.appserv.management.base.AMX#getJ2EEType}. */
         public static final String J2EE_TYPE =
XTypes.HTTP_PROTOCOL_CONFIG;
+ /**
+ <b>DO NOT USE, use {_at_link #getDefaultType}</b>
+ @deprecated
+ */
         public String getDefaultResponseType();
+
         /**
- Legal values include:
- <ul>
- <li>"text/html</li>
- <li>ISO-8859-1</li>
- <li>en</li>
- </ul>
+ <b>DO NOT USE, use {_at_link #setDefaultType}</b>
+ @deprecated
         */
         public void setDefaultResponseType( final String value );
         public boolean getDNSLookupEnabled();
         public void setDNSLookupEnabled( final boolean value );
+
+ /**
+ Example: "text/html; charset=iso-8859-1".
+ */
+ public String getForcedType();
+ /**
+ See {_at_link #getForcedType}.
+ */
+ public void setForcedType(String forcedType);
+
+
+ /**
+ @see HTTPProtocolConfigKeys#FORCED_RESPONSE_TYPE_KEY
+ @deprecated
+ */
+ public String getDefaultType();
+ public void setDefaultType(String defaultType);
+
         /**
+ <b>DO NOT USE, use {_at_link #getResponseType}</b>
                 @see HTTPProtocolConfigKeys#FORCED_RESPONSE_TYPE_KEY
+ @deprecated
         */
         public String getForcedResponseType();
         /**
                 @see HTTPProtocolConfigKeys#FORCED_RESPONSE_TYPE_KEY
+ @deprecated
         */
         public void setForcedResponseType( final String value );
Index: src/java/com/sun/appserv/management/config/
HTTPProtocolConfigKeys.java
===================================================================
RCS file: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
management/config/HTTPProtocolConfigKeys.java,v
retrieving revision 1.2
diff -w -u -r1.2 HTTPProtocolConfigKeys.java
--- src/java/com/sun/appserv/management/config/
HTTPProtocolConfigKeys.java 5 May 2007 05:30:33 -0000 1.2
+++ src/java/com/sun/appserv/management/config/
HTTPProtocolConfigKeys.java 25 May 2007 23:58:47 -0000
@@ -34,11 +34,6 @@
   * holder.
   */

-/*
- * $Header: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
management/config/HTTPProtocolConfigKeys.java,v 1.2 2007/05/05
05:30:33 tcfujii Exp $
- * $Revision: 1.2 $
- * $Date: 2007/05/05 05:30:33 $
- */
package com.sun.appserv.management.config;
/**
@@ -56,6 +51,17 @@
         public static final String DNS_LOOKUP_ENABLED_KEY
= "DNSLookupEnabled";
         /**
+ See {_at_link HTTPProtocolConfig#setForcedType}.
+ */
+ public static final String FORCED_TYPE_KEY
= "ForcedType";
+
+ /**
+ See {_at_link HTTPProtocolConfig#setDefaultType}.
+ */
+ public static final String DEFAULT_TYPE_KEY
= "DefaultType";
+
+
+ /**
                 See {_at_link HTTPProtocolConfig#setForcedResponseType}
for legal values.
                 The response type to be forced if the content served
cannot
          be matched by any of the MIME mappings for extensions.
@@ -63,11 +69,13 @@
          content-type, encoding, language, charset
          <p>
          Example: "text/html; charset=iso-8859-1"
-
+ @deprecated
          */
         public static final String
FORCED_RESPONSE_TYPE_KEY = "ForcedResponseType";
+
         /**
                 See {_at_link #FORCED_RESPONSE_TYPE_KEY}.
+ @deprecated
          */
         public static final String DEFAULT_RESPONSE_TYPE_KEY
= "DefaultResponseType";
         public static final String
SSL_ENABLED_KEY = "SSLEnabled";