TIMEOUT: 17:00 PST May 3
https://glassfish.dev.java.net/issues/show_bug.cgi?id=2965
Index: admin-core/admin/src/java/com/sun/enterprise/admin/meta/naming/
NameParser.java
===================================================================
RCS file: /cvs/glassfish/admin-core/admin/src/java/com/sun/enterprise/
admin/meta/naming/NameParser.java,v
retrieving revision 1.3
diff -w -u -r1.3 NameParser.java
--- admin-core/admin/src/java/com/sun/enterprise/admin/meta/naming/
NameParser.java 25 Dec 2005 03:47:40 -0000 1.3
+++ admin-core/admin/src/java/com/sun/enterprise/admin/meta/naming/
NameParser.java 3 May 2007 18:53:31 -0000
@@ -42,9 +42,9 @@
public class NameParser
{
+ // Why is 'Vector' used? Thread safety? Then 'mString' is not
thread-safe.
private String mString = null;
- private Vector mNameParts = null;
-
+ private final Vector mNameParts;
/**
Default constructor for initialization purpose.
@@ -57,8 +57,7 @@
/**
- A method in the public interface of this class which
initializes
- the parsing process.
+ Initializes the parsing process.
<p>
@param the string to be parsed. Should be non null.
<p>
@@ -521,9 +520,9 @@
private String removeSubscript(String npString)
{
String subscriptLessString = null;
- int leftIndex = npString.indexOf
(Tokens.kSubScriptBeginnerChar);
+ final int leftIndex = npString.indexOf
(Tokens.kSubScriptBeginnerChar);
- if (npString != null || npString.length() > 0)
+ if ( npString.length() > 0 )
{
if(leftIndex != -1)
{