admin@glassfish.java.net

Re: Code Review Issue#2994

From: Ken Paulsen <Ken.Paulsen_at_Sun.COM>
Date: Tue, 22 May 2007 12:35:01 -0700

Looks good to me!  Go ahead and check it in. :)

Ken

Ana Caballero wrote:
Can someone please review and let me kow if it's okay to checkin?  Thank you.
Ana Caballero wrote:
Attached is the file and below are the diffs for issue#2994-refreshing monitoring information for jdbc-connection-pool selects in-correct connection pool.  Please let me know if it's okay to check-in.

Thanks,
Ana

cvs diff -- monitorResources.jsf (in directory C:\april\glassfish\admin-gui\src\docroot\standalone\)
Index: monitorResources.jsf
===================================================================
RCS file: /cvs/glassfish/admin-gui/src/docroot/standalone/monitorResources.jsf,v
retrieving revision 1.4
diff -r1.4 monitorResources.jsf
45a46
>         getRequestValue(key="viewVal" value=>$attribute{viewVal} );
64c65
<                                 redirect(page="monitorResources.jsf?instanceName=$pageSession{instanceName}&configName=$pageSession{configName}");
---
>                                 redirect(page="monitorResources.jsf?instanceName=$pageSession{instanceName}&configName=$pageSession{configName}&viewVal=#{viewVal}");





$page{instanceName} ); getRequestValue(key="viewVal" value=>$attribute{viewVal} ); getConfigName(target="$pageSession{instanceName}" configName=>$page{configName}); /> #include treeBreadcrumbs.inc #include "standalone/standaloneInstanceTabs.inc" $attribute{monitorList} ObjectName=>$pageSession{viewVal}); getStatisticData( MonitorObject="#{viewVal}" StatisticData=>$attribute{statisticData}); /> "
"