If we change the "names" of the default profiles that
are bundled with the product, then this would have to
change. But the idea is that going ahead, if this feature
is liked by developers/administrators, they can actually
ask us to take the "default-config" from a particular profile.
So, I do think that accepting the name of the profile is
a good idea and makes the code flexible. It's just that
for GlassFish V2, admin console sends in a profile name
which is "cluster" (or whatever we decide). Going ahead, it
might present you a list of profiles that are available
to choose the default-config from. Again, the reason is
that the default-config might be different for different
profiles.
Bill Shannon wrote:
> Kedar Mhaswade wrote:
>>> Is there a more detailed spec for exactly what is done when the button
>>> is pushed?
>> Spec, well a spec of sorts --
>> http://wiki.glassfish.java.net/gfwiki/Wiki.jsp?page=ProvidingClusterSupport2DeveloperDomains
>
>
> According to that spec, you're actually depending on the *name* of a
> profile that includes cluster support. I've said several times I
> think it's a bad idea to have any builtin knowledge of the names of
> any profiles. As you know, we're having a separate discussion about
> changing the names of the profiles. I would not want such a change
> to break this code.
>
> If you want to externalize the default-config details, instead of wiring
> it into the code as you've done for the other changes, I suggest you
> have a template file used only for the purposes of this operation,
> separate from any profile template files.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>