Thanks.
Fix committed.
On May 17, 2007, at 4:31 PM, Sreenivas Munnangi wrote:
> Lloyd L Chambers wrote:
>
>> Sreeni,
>>
>> Please review these diffs. Starting and stopping a non-DAS
>> server works fine, and shows the correct status.
>>
>> The only material change is the addition of "implements
>> MBeanRegistration".
>>
>> The other changes are just 'final' and 'volatile' (for thread
>> safety).
>
> Looks fine.
>
>>
>> Thanks,
>> Lloyd
>>
>> RCS file: /cvs/glassfish/admin/mbeans/src/java/com/sun/enterprise/
>> management/model/J2EEManagedObjectMdl.java,v
>> retrieving revision 1.5
>> -public abstract class J2EEManagedObjectMdl {
>> +public abstract class J2EEManagedObjectMdl implements
>> MBeanRegistration { <===============
>> // name - key attribute for the managed object
>> - private String name;
>> - private boolean stateManageable;
>> - private boolean statisticsProvider;
>> - private boolean eventProvider;
>> - private String serverName;
>> + private final String name;
>> + private final boolean stateManageable;
>> + private final boolean statisticsProvider;
>> + private final boolean eventProvider;
>> + private final String serverName;
>>
>> - private MBeanServer mServer;
>> - private ObjectName mSelfObjectName;
>> + private volatile MBeanServer mServer;
>> + private volatile ObjectName mSelfObjectName;
>> protected final Logger mLogger;
>> J2EEManagedObjectMdl(String name,boolean state, boolean
>> statistics, boolean events) {
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>