admin@glassfish.java.net

Re: CODE REVIEW: IntEntry.java (trivial)

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Thu, 17 May 2007 10:20:40 -0700

Kedar,

This file was previously code reviewed by admin_at_glassfish. I
introduced this problem when fixing another.

It's a FindBugs complaint.

How much OVERHEAD do we have to suffer for trivial fixes like this?
It's really getting annoying and demotivating to bother with crap
like this.

Bureaucracy rum amok: "We don't know which department is
responsible, but please get approval there first!!!"

Lloyd

On May 17, 2007, at 10:14 AM, Kedar Mhaswade wrote:

> I don't know who the owner of this Class is. IMO, this is not used
> by admin code.
>
> Please try dev_at_glassfish.
> Also, send the associated IT issue.
>
> Thanks.
>
> Lloyd L Chambers wrote:
>> Timeout: 2pm 5/17
>>
>> Index: src/java/com/sun/enterprise/util/collection/IntEntry.java
>> ===================================================================
>> RCS file: /cvs/glassfish/appserv-commons/src/java/com/sun/
>> enterprise/util/collection/IntEntry.java,v
>> retrieving revision 1.5
>> diff -r1.5 IntEntry.java
>> 64c64
>> < return (int)key ^ (int)(key>>32);
>> ---
>> > return key;
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>