admin@glassfish.java.net

Re: CODE REVIEW: FindBugs: admin-ee/jes-mf

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Fri, 04 May 2007 09:17:24 -0700

Bill,

Please include the *file name*, and preferably the diffs when
commenting on a change.

I think you are referring to ObjectNames.java. I used intern() to
avoid changing every line, though in the 2nd case, I apparently
changed my mind and used equals(), forgetting to remove the call to
intern().

If you prefer, I can change all uses to equals().

Is there something *wrong* with using intern()? (other than the mild
surprise the comparisons produce)?

Lloyd

On May 4, 2007, at 12:55 AM, Bill Shannon wrote:

> Again, this claims to be a generated file.
>
> You added the call to intern *and* changed the comparison to use
> equals, why?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>