admin@glassfish.java.net

Re: Code Review Issue #3089

From: Ana Caballero <Ana.Caballero_at_Sun.COM>
Date: Thu, 31 May 2007 15:02:33 -0700

Hi Ken,

Thanks for the review. I've made the change for the developer profile.

Thanks,
Ana

Ken Paulsen wrote:

>
> Hi Ana,
>
> This looks like it will work for the cluster tabs. However, it
> appears the the developer profile uses a different session key. I
> think you need "serverInstTabs" for cluster.jsf. I didn't test this,
> though.
>
> If you have it working in cluster, go ahead and check that in. For
> developer, make sure you have it working and/or the right session key
> is being used.
>
> Thanks!!
>
> Ken
>
> Ana Caballero wrote:
>
>> Please review for Issue#3089-Common Tasks link doesnt work properly.
>> See diffs below and please let me know if it's okay to checkin.
>> Thank you. Ana
>>
>> Index: clusterCommonTask.jsf
>> ===================================================================
>> RCS file: /cvs/glassfish/admin-gui/src/docroot/clusterCommonTask.jsf,v
>> retrieving revision 1.14
>> diff -r1.14 clusterCommonTask.jsf
>> 144a145
>> >
>> setSessionAttribute(key="standaloneTabs" value="runtime");
>> Index: commonTask.jsf
>> ===================================================================
>> RCS file: /cvs/glassfish/admin-gui/src/docroot/commonTask.jsf,v
>> retrieving revision 1.15
>> diff -r1.15 commonTask.jsf
>> 99a100
>> >
>> setSessionAttribute(key="standaloneTabs" value="runtime");
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> #include "jbi/pe/inc/alertBox.inc" #include "commonTaskDoc.inc"
>> ------------------------------------------------------------------------
>>
>> #include "jbi/pe/inc/alertBox.inc" #include "commonTaskDoc.inc"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net For
> additional commands, e-mail: admin-help_at_glassfish.dev.java.net